Closed Bug 1309988 Opened 7 years ago Closed 5 years ago

[webvr] Change InputFrameID to unsigned

Categories

(Core :: WebVR, defect)

Product:
Core
Component:
WebVR
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: kip, Assigned: kip, NeedInfo)

References

Details

(Whiteboard: [webvr])

Attachments

(1 file)

0001-Bug-1309988-Change-InputFrameID-to-unsigned-r-kearwo.patch
4.70 KB, patch
kip
: review+
Details | Diff | Splinter Review 
The refactoring in Bug 1306427 removed all cases where negative values of aInputFrameID would be passed into VRDisplayHost::SubmitFrame.

A cleanup task to follow up is to change aInputFrameID to an uint32 and remove the "< 0" check at the top of the VRDisplayHost::SubmitFrame function.
Assignee: kgilbert → gwright
Comment on attachment 8802643 [details] [diff] [review]
0001-Bug-1309988-Change-InputFrameID-to-unsigned-r-kearwo.patch

Looks good, thanks for cleaning this up!
Attachment #8802643 - Flags: review?(kgilbert) → review+
Pushed by gwright@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1559b3712f2
Change InputFrameID to unsigned r=kearwood
had to back this out because this cause merge conflicts to m-c like merging xpcom/base/ErrorList.h
warning: conflicts while merging gfx/vr/VRDisplayHost.cpp! (edit, then use 'hg resolve --mark')
Flags: needinfo?(gwright)
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3de60b2f630
Backed out changeset c1559b3712f2 for causing merge conflicts with m-c/autoland
Whiteboard: [webr]
Whiteboard: [webr] → [webvr]
Component: Graphics → WebVR
Assignee: gw → kgilbert
There are no longer any instances of a signed inputFrameID.  Other unrelated fixes have replaced this code.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.