Closed
Bug 1309988
Opened 8 years ago
Closed 6 years ago
[webvr] Change InputFrameID to unsigned
Categories
(Core :: WebVR, defect)
Core
WebVR
Tracking
()
RESOLVED
FIXED
People
(Reporter: kip, Assigned: kip, NeedInfo)
References
Details
(Whiteboard: [webvr])
Attachments
(1 file)
|
4.70 KB,
patch
|
kip
:
review+
|
Details | Diff | Splinter Review |
The refactoring in Bug 1306427 removed all cases where negative values of aInputFrameID would be passed into VRDisplayHost::SubmitFrame. A cleanup task to follow up is to change aInputFrameID to an uint32 and remove the "< 0" check at the top of the VRDisplayHost::SubmitFrame function.
|
||
Updated•8 years ago
|
Assignee: kgilbert → gwright
|
|
||
Comment 1•8 years ago
|
||
Attachment #8802643 -
Flags: review?(kgilbert)
|
Assignee | |
Comment 2•8 years ago
|
||
Comment on attachment 8802643 [details] [diff] [review] 0001-Bug-1309988-Change-InputFrameID-to-unsigned-r-kearwo.patch Looks good, thanks for cleaning this up!
Attachment #8802643 -
Flags: review?(kgilbert) → review+
Pushed by gwright@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c1559b3712f2 Change InputFrameID to unsigned r=kearwood
|
||
Comment 4•8 years ago
|
||
had to back this out because this cause merge conflicts to m-c like merging xpcom/base/ErrorList.h warning: conflicts while merging gfx/vr/VRDisplayHost.cpp! (edit, then use 'hg resolve --mark')
Flags: needinfo?(gwright)
Backout by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d3de60b2f630 Backed out changeset c1559b3712f2 for causing merge conflicts with m-c/autoland
|
||
Updated•8 years ago
|
Whiteboard: [webr]
|
|
||
Updated•8 years ago
|
Whiteboard: [webr] → [webvr]
|
|
Assignee | |
Updated•7 years ago
|
Component: Graphics → WebVR
|
|
Assignee | |
Updated•6 years ago
|
Assignee: gw → kgilbert
|
|
Assignee | |
Comment 6•6 years ago
|
||
There are no longer any instances of a signed inputFrameID. Other unrelated fixes have replaced this code.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•