Rename and lint deprecated .eslintrc files

RESOLVED FIXED in 5.4

Status

Calendar
General
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

unspecified

Details

Attachments

(3 attachments)

(Assignee)

Description

a year ago
This is a mirror of bug 1251003, with the addition of actually having eslint lint the config file.
(Assignee)

Comment 1

a year ago
Created attachment 8800847 [details] [diff] [review]
Fix - v1
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #8800847 - Flags: review?(makemyday)
(Assignee)

Comment 2

a year ago
Created attachment 8800848 [details] [diff] [review]
Fix - v1 (no whitespaces)

For convenience, here is the same patch but with whitespace changes ignored.

Comment 3

a year ago
Comment on attachment 8800847 [details] [diff] [review]
Fix - v1

Review of attachment 8800847 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, I always was wondering why the deprecated fromat was used.
Attachment #8800847 - Flags: review?(makemyday) → review+
(Assignee)

Comment 4

a year ago
https://hg.mozilla.org/comm-central/rev/b0d4176aaa7a033ce5e725a922a0d9159728c7d4
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → 5.4
Since bug 1251003 landed, we need to cope for the changes in the toolkit eslintrc files.

When linting, I get a lot of indentation errors.
Have these been there before?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 8803608 [details] [diff] [review]
Fix V2

This change the filenames in the config files of calendar
Attachment #8803608 - Flags: review?(philipp)
(Assignee)

Comment 7

a year ago
Comment on attachment 8803608 [details] [diff] [review]
Fix V2

Good catch, thanks. r=philipp

For the indent changes, this is a pending issue. I've fixed most of the xbl processor issues, but the one missing is to detect indent correctly.

m-c uses two space indent in xbl files, even in the code. We use two space for the xml and four space for the code. I have a patch pending that uses the closing tag indent to check what the base indent would be. This works pretty well for both m-c and c-c, as long as we indent all our xbl method bodies by two more spaces.

In the meanwhile, go to  mozilla/tools/lint/eslint/node_modules/eslint-plugin-mozilla/lib/processors/xbl-bindings.js and change INDENT from 2 to 4. This will reset as soon as you mach eslint --setup again, if that is annoying to you then you could also change it in the source (drop node_modules from above path) and then run mach eslint --setup again.
Attachment #8803608 - Flags: review?(philipp) → review+
(Assignee)

Comment 8

a year ago
https://hg.mozilla.org/comm-central/rev/da9bb0d96cc8487f057e1fe1c7e06b2e5b0b359e
Status: REOPENED → RESOLVED
Last Resolved: a year agoa year ago
Resolution: --- → FIXED
(Assignee)

Comment 9

a year ago
Filed bug 1312191 for the indent issue btw
You need to log in before you can comment on or make changes to this bug.