Closed Bug 1310022 Opened 5 years ago Closed 5 years ago

cleanup test-charset-upgrade.js

Categories

(Thunderbird :: Testing Infrastructure, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 52.0

People

(Reporter: aceman, Assigned: aceman)

References

Details

Attachments

(1 file)

1. We can use some existing helpers instead of open-coding in test-charset-upgrade.js, like setup_msg_contents
2. There is teardownmodule() function twice.
3. Calling Send later then does not wait for window close.
Attached patch patchSplinter Review
Attachment #8800866 - Flags: review?(mkmelin+mozilla)
Blocks: 1310024
Comment on attachment 8800866 [details] [diff] [review]
patch

Review of attachment 8800866 [details] [diff] [review]:
-----------------------------------------------------------------

Drive-by review. I guess it's all going to change again in bug 1310024, so let's get this one here done.

::: mail/test/mozmill/composition/test-charset-upgrade.js
@@ -45,5 @@
> -                   .localFoldersServer
> -                   .rootFolder
> -                   .containsChildNamed("Outbox")) {
> -     create_folder("Outbox", [Ci.nsMsgFolderFlags.Outbox]);
> -  }

Why are you removing this? What are you doing in bug 1310024 for this one?
 outboxFolder = get_special_folder(Ci.nsMsgFolderFlags.Queue);
right? So that equates to creating it.
Am I missing something?
Attachment #8800866 - Flags: review?(mkmelin+mozilla) → review+
(In reply to Jorg K (GMT+2) from comment #2)
> ::: mail/test/mozmill/composition/test-charset-upgrade.js
> @@ -45,5 @@
> > -                   .localFoldersServer
> > -                   .rootFolder
> > -                   .containsChildNamed("Outbox")) {
> > -     create_folder("Outbox", [Ci.nsMsgFolderFlags.Outbox]);
> > -  }
> 
> Why are you removing this? What are you doing in bug 1310024 for this one?
>  outboxFolder = get_special_folder(Ci.nsMsgFolderFlags.Queue);
> right? So that equates to creating it.
> Am I missing something?

Yes - "missing". For Outbox we do not create it automatically, I made an exception in the function.
We just expect it is there, or we fail.
OK. You have my r+ already. Just put a big comment in bug 1310024 to explain when/why you're creating folders and when/why you're not.
Thanks. Comment added.
https://hg.mozilla.org/comm-central/rev/118a8202a7457b3d9ffecbbe97feff4e8287bf70
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 52.0
You need to log in before you can comment on or make changes to this bug.