1310035 - Detection of expired credentials isn't working anymore

Status: RESOLVED FIXED

(Taskcluster :: UI, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

Several times now, I've loaded https://tools.taskcluster.net thinking "I'll have to sign in again", only to see my cliendId in the upper right.  But indeed, the credentials are not valid, and on the very next page load, the menu changes to read "Sign In".

Something in the logic to handle credential expiration is broken..

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

I just loaded a page view in this condition, and I see that the LocalStorage has been deleted

 35 export const loadCredentials = () => {
..
 46     if (creds.certificate && creds.certificate.expiry < Date.now()) {
 47       saveCredentials(null); // clear credentials

so this part cleared the credentials.  That should have sent a credentials-changed message
 13     window.dispatchEvent(new window.CustomEvent('credentials-changed', { detail: null }));

but perhaps there's an ordering issue here, where the listener for that event is not yet set up at the time?

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

I can confirm, the listening for `credentials-changed` only occurs after the credentials are deleted by the auth service.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

https://github.com/taskcluster/taskcluster-tools/pull/167

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/taskcluster/taskcluster-tools

https://github.com/taskcluster/taskcluster-tools/commit/607caa0d003a4eb262ef03ba529839d326c71fe6
Bug 1310035: display 'sign in' when credentials are expired at page load (#167)