1310055 - [RTL] The left and right keyboard navigation of DevTools tree nodes are wrong direction in RTL locales

Status: NEW

(DevTools :: General, defect, P3)

Description

[Tim Nguyen :ntim]

+++ This bug was initially created as a clone of Bug #1261778 +++

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160315153207

Steps to reproduce:

1. Start any versions Firefox with RTL locales (e.g. arabic)
2. Go to any tree nodes (e.g. Storage inspector/memory tool/perf tool)
3. Hit the left and right key on a collapsed node


Actual results:

Left key: RTL tree node (twisty) is closed.
Right key: RTL tree node is opened.


Expected results:

Left key: RTL tree node (twisty) should be opened.
Right key: RTL tree node should be closed.

Comment 1

[Itiel]

Attachment: Bug 1310055 - [RTL] Fix left and right keyboard navigation of DevTools tree nodes

Comment 2

[Itiel]

Hi nchevobbe, just pinging you to verify that you saw the review request for this bug? Thanks!

Comment 3

[Itiel]

Attachment: Bug 1310055 - [RTL] Fix left and right keyboard navigation of DevTools tree nodes

Comment 4

[Patrick Brosset <:pbro>]

Hi Itiel, how are things going here? I'm just checking in to see if you need help to continue working on this bug. Looking at phabricator, it says you were planning changes, but you also seemed to have a question for Nicolas.
Let us know how we can help.

Comment 5

[Itiel]

(In reply to Patrick Brosset <:pbro> from comment #4)

Hi Itiel, how are things going here? I'm just checking in to see if you need help to continue working on this bug. Looking at phabricator, it says you were planning changes, but you also seemed to have a question for Nicolas.
Let us know how we can help.

I flagged it as plan changes just so it won't be on Nicolas queue.
Seeing that I had too many difficulties and Nicolas must be swamped with other important stuff, I didn't want to bother him with it, at least until I had more progress (which didn't happen since then).

So, I'd like to complete the patch but I'm out of ideas. If someone can address the last issue there or can advise on how to do that, I'd appreciate that :-)

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Itiel, the last Phab revision indicates that you want to introduce some more changes to the patch.
Are you still planning to work on this?

Thanks for the help!
Honza

Comment 7

[Itiel]

Not (In reply to Jan Honza Odvarko [:Honza] (always need-info? me) from comment #6)

Itiel, the last Phab revision indicates that you want to introduce some more changes to the patch.
Are you still planning to work on this?

Thanks for the help!
Honza

See comment 5.
I don't plan to work on this in the foreseeable future.
The phab revision is marked as Changes Planned and not Abandoned just to not lose the progress in case I come back to it.

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Ok, I see, thanks for the update Itiel!

Honza