Closed
Bug 1310067
Opened 8 years ago
Closed 8 years ago
Cannot compile DispatchTraceKindTyped by VS15 Preview
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla53
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(1 file)
|
1.56 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
Like gcc and clang, VS "15" requires an explicit template declaration...
|
Assignee | |
Comment 1•8 years ago
|
||
VS15Preview' s _MSC_VER is 1910.
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → m_kato
|
|
Assignee | |
Comment 2•8 years ago
|
||
|
|
Assignee | |
Comment 3•8 years ago
|
||
Comment on attachment 8801051 [details] [diff] [review] VS15 doesn't require JS_DEPENDENT_TEMPLATE_HINT workaround Upcoming VS "15" preview doesn't require workaround for JS_DEPENDENT_TEMPLATE_HINT.
Attachment #8801051 -
Flags: review?(terrence.d.cole)
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8801051 [details] [diff] [review] VS15 doesn't require JS_DEPENDENT_TEMPLATE_HINT workaround Terrence left.
Attachment #8801051 -
Flags: review?(terrence.d.cole) → review?(jcoppeard)
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8801051 [details] [diff] [review] VS15 doesn't require JS_DEPENDENT_TEMPLATE_HINT workaround Review of attachment 8801051 [details] [diff] [review]: ----------------------------------------------------------------- Great, thanks for fixing. ::: js/public/TraceKind.h @@ +168,1 @@ > // specialization of operator() because it is a dependent template. MSVC, on You added a reference to 'VS15' but the comment already talks about 'MSVC' - can you update the comment to make it clear that versions 15 and above require 'template' to be present and those below require it to be absent?
Attachment #8801051 -
Flags: review?(jcoppeard) → review+
|
|
Assignee | |
Comment 6•8 years ago
|
||
(In reply to Jon Coppeard (:jonco) from comment #5) > Comment on attachment 8801051 [details] [diff] [review] > VS15 doesn't require JS_DEPENDENT_TEMPLATE_HINT workaround > > Review of attachment 8801051 [details] [diff] [review]: > ----------------------------------------------------------------- > > Great, thanks for fixing. > > ::: js/public/TraceKind.h > @@ +168,1 @@ > > // specialization of operator() because it is a dependent template. MSVC, on > > You added a reference to 'VS15' but the comment already talks about 'MSVC' - > can you update the comment to make it clear that versions 15 and above > require 'template' to be present and those below require it to be absent? VS 2017 becomes correct name today. I will land this with 2017.
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/mozilla-inbound/rev/e5164f497e42 VS2017 doesn't require JS_DEPENDENT_TEMPLATE_HINT workaround. r=jonco
|
||
Comment 8•8 years ago
|
||
Sorry had to back this out for bustage, https://treeherder.mozilla.org/logviewer.html#?job_id=39529200&repo=mozilla-inbound
Flags: needinfo?(m_kato)
Backout by ihsiao@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/665038e5ef2b Backed out changeset e5164f497e42 for bustage
|
||
Comment 11•8 years ago
|
||
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/mozilla-inbound/rev/59375acb5ae8 VS2017 doesn't require JS_DEPENDENT_TEMPLATE_HINT workaround. r=jonco
|
||
Comment 12•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/59375acb5ae8
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
|
||
Comment 13•7 years ago
|
||
Do we need this in aurora? Or can we just mark this wontfix?
|
|
Assignee | |
Comment 14•7 years ago
|
||
(In reply to Hannes Verschore [:h4writer] from comment #13) > Do we need this in aurora? Or can we just mark this wontfix? No, uplift is unnecessary. Because we cannot still build SpiderMonkey using VS2017 due to bug 1319971 etc.
|
|
||
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•