Cannot compile DispatchTraceKindTyped by VS15 Preview

RESOLVED FIXED in Firefox 53

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
mozilla53
Unspecified
Windows
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 wontfix, firefox53 fixed)

Details

Attachments

(1 attachment)

Like gcc and clang, VS "15" requires an explicit template declaration...
VS15Preview' s _MSC_VER is 1910.
Assignee: nobody → m_kato
Comment on attachment 8801051 [details] [diff] [review]
VS15 doesn't require JS_DEPENDENT_TEMPLATE_HINT workaround

Upcoming VS "15" preview doesn't require workaround for JS_DEPENDENT_TEMPLATE_HINT.
Attachment #8801051 - Flags: review?(terrence.d.cole)
Comment on attachment 8801051 [details] [diff] [review]
VS15 doesn't require JS_DEPENDENT_TEMPLATE_HINT workaround

Terrence left.
Attachment #8801051 - Flags: review?(terrence.d.cole) → review?(jcoppeard)
Comment on attachment 8801051 [details] [diff] [review]
VS15 doesn't require JS_DEPENDENT_TEMPLATE_HINT workaround

Review of attachment 8801051 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks for fixing.

::: js/public/TraceKind.h
@@ +168,1 @@
>  // specialization of operator() because it is a dependent template. MSVC, on

You added a reference to 'VS15' but the comment already talks about 'MSVC' - can you update the comment to make it clear that versions 15 and above require 'template' to be present and those below require it to be absent?
Attachment #8801051 - Flags: review?(jcoppeard) → review+
(In reply to Jon Coppeard (:jonco) from comment #5)
> Comment on attachment 8801051 [details] [diff] [review]
> VS15 doesn't require JS_DEPENDENT_TEMPLATE_HINT workaround
> 
> Review of attachment 8801051 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Great, thanks for fixing.
> 
> ::: js/public/TraceKind.h
> @@ +168,1 @@
> >  // specialization of operator() because it is a dependent template. MSVC, on
> 
> You added a reference to 'VS15' but the comment already talks about 'MSVC' -
> can you update the comment to make it clear that versions 15 and above
> require 'template' to be present and those below require it to be absent?

VS 2017 becomes correct name today.  I will land this with 2017.
Blocks: vs2017
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5164f497e42
VS2017 doesn't require JS_DEPENDENT_TEMPLATE_HINT workaround. r=jonco
Sorry had to back this out for bustage, https://treeherder.mozilla.org/logviewer.html#?job_id=39529200&repo=mozilla-inbound
Flags: needinfo?(m_kato)
Backout by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/665038e5ef2b
Backed out changeset e5164f497e42 for bustage
Sorry, that has typo.  I will reland it
Flags: needinfo?(m_kato)
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/59375acb5ae8
VS2017 doesn't require JS_DEPENDENT_TEMPLATE_HINT workaround. r=jonco
https://hg.mozilla.org/mozilla-central/rev/59375acb5ae8
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Do we need this in aurora? Or can we just mark this wontfix?
(In reply to Hannes Verschore [:h4writer] from comment #13)
> Do we need this in aurora? Or can we just mark this wontfix?

No, uplift is unnecessary.  Because we cannot still build SpiderMonkey using VS2017 due to bug 1319971 etc.
You need to log in before you can comment on or make changes to this bug.