Closed
Bug 1310076
Opened 9 years ago
Closed 9 years ago
Add 'datetime-local' to the list of valid types attributes for <input>
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: jessica, Assigned: jessica)
References
Details
Attachments
(1 file, 1 obsolete file)
|
42.51 KB,
patch
|
jessica
:
review+
|
Details | Diff | Splinter Review |
No description provided.
| Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jjong
| Assignee | ||
Comment 1•9 years ago
|
||
Removed todos in test files that has only 'datetime' left, since 'datatime' is removed from the spec.
Attachment #8803267 -
Flags: review?(bugs)
Comment 2•9 years ago
|
||
Comment on attachment 8803267 [details] [diff] [review]
patch, v1.
>+ bool DoesStepApply() const {
nit, { should be on its own line
>+ bool DoesValueAsNumberApply() const {
ditto
Attachment #8803267 -
Flags: review?(bugs) → review+
| Assignee | ||
Comment 3•9 years ago
|
||
Addressed nits in comment 2, carrying r+.
Attachment #8803267 -
Attachment is obsolete: true
Attachment #8803816 -
Flags: review+
| Assignee | ||
Comment 4•9 years ago
|
||
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/88a29fca0c06
Add 'datetime-local' to the list of valid types attributes for <input>. r=smaug
Keywords: checkin-needed
Comment 6•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•