Closed Bug 1310076 Opened 3 years ago Closed 3 years ago

Add 'datetime-local' to the list of valid types attributes for <input>

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: jessica, Assigned: jessica)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → jjong
Attached patch patch, v1. (obsolete) — Splinter Review
Removed todos in test files that has only 'datetime' left, since 'datatime' is removed from the spec.
Attachment #8803267 - Flags: review?(bugs)
Comment on attachment 8803267 [details] [diff] [review]
patch, v1.

>+  bool DoesStepApply() const {
nit, { should be on its own line

>+  bool DoesValueAsNumberApply() const {
ditto
Attachment #8803267 - Flags: review?(bugs) → review+
Attached patch patch, v2.Splinter Review
Addressed nits in comment 2, carrying r+.
Attachment #8803267 - Attachment is obsolete: true
Attachment #8803816 - Flags: review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/88a29fca0c06
Add 'datetime-local' to the list of valid types attributes for <input>. r=smaug
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/88a29fca0c06
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.