Closed Bug 1310092 Opened 3 years ago Closed 3 years ago

Intermittent browser/components/originattributes/test/browser/browser_favicon_userContextId.js | Test timed out -

Categories

(Firefox :: General, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Firefox 52
Tracking Status
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: timhuang)

References

Details

(Keywords: intermittent-failure, Whiteboard: [OA])

Attachments

(1 file)

This test was added in bug 1277803 and started failing almost right away.
Blocks: 1277803
Flags: needinfo?(tihuang)
Tim already got the root cause and has a solution in mind. :)
Assignee: nobody → tihuang
Priority: -- → P2
There are two possibilities that could trigger this time out problem:

1. The delayed completion of the second favicon load of the first test might leave an entry in the cache after the second test started. So, the event 'http-on-modify-request' will not be sent, then the test will be blocked by waiting for this event. To resolve this, I will use different sites for these two tests, which means they will not share the same entry during the test.

2. The Places favicon load finished too quick to be caught by the waitOnFaviconLoaded(). To address this, I will start the observer earlier before the tab has been created.
Flags: needinfo?(tihuang)
Comment on attachment 8807075 [details]
Bug 1310092 - Fixing the timeout problem of the favicon test for userContextIds.

https://reviewboard.mozilla.org/r/90354/#review90032
Attachment #8807075 - Flags: review?(amarchesini) → review+
Try looks good.
Keywords: checkin-needed
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/da35d5511e92
Fixing the timeout problem of the favicon test for userContextIds. r=baku
Keywords: checkin-needed
Whiteboard: [OA]
https://hg.mozilla.org/mozilla-central/rev/da35d5511e92
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in before you can comment on or make changes to this bug.