Closed Bug 1310094 Opened 4 years ago Closed 4 years ago

Remove UserCustomizations.jsm

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.
Blocks: nukeb2g
Attachment #8800976 - Flags: review?(myk)
Attachment #8800981 - Flags: review?(mcmanus) → review+
Comment on attachment 8800976 [details] [diff] [review]
Remove UserCustomizations.jsm

Review of attachment 8800976 [details] [diff] [review]:
-----------------------------------------------------------------

netwerk/ipc/NeckoParent.cpp also references nsIAppsService::isExtensionResource:

https://dxr.mozilla.org/mozilla-central/rev/9079d167112122805f99f57bb8856e1b1675af0f/netwerk/ipc/NeckoParent.cpp#663

So that needs to be removed as well.
Attachment #8800976 - Flags: review?(myk) → review-
Did you have a fix in mind instead of attachment 8800981 [details] [diff] [review]?
Flags: needinfo?(myk)
Attachment #8800976 - Flags: review- → review+
(In reply to :Ehsan Akhgari from comment #4)
> Did you have a fix in mind instead of attachment 8800981 [details] [diff] [review]
> [review]?

Ah, no, sorry, I missed that you'd fixed that in a separate patch. r+ in that case.
Flags: needinfo?(myk)
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6588006ec86e
Part 1: Remove support for loading b2g extensions from AllocPRemoteOpenFileParent; r=mcmanus
https://hg.mozilla.org/integration/mozilla-inbound/rev/e71ee6ee03c3
Part 2: Remove UserCustomizations.jsm; r=myk
https://hg.mozilla.org/mozilla-central/rev/6588006ec86e
https://hg.mozilla.org/mozilla-central/rev/e71ee6ee03c3
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Assignee: nobody → ehsan
No longer blocks: 1369194
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.