Closed
Bug 1310117
Opened 8 years ago
Closed 8 years ago
Stylo: implement filter
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: shinglyu, Assigned: shinglyu)
References
Details
Attachments
(3 files)
Implement CSS Filters except url (blocked) and drop-shadow (difficult)
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Attachment #8801000 -
Flags: review?(manishearth)
Updated•8 years ago
|
Assignee: nobody → slyu
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
Filters in action.
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8801000 [details] Bug 1310117 - Implement Stylo CSS filter except url and drop-shadow. https://reviewboard.mozilla.org/r/85800/#review84442 Overall lgtm. Do you intend to add shadow support in this bug? ::: layout/style/ServoBindings.cpp:853 (Diff revision 1) > +void > +Gecko_ResetFilters(nsStyleEffects* effects, size_t new_len) > +{ > + effects->mFilters.Clear(); > + effects->mFilters.SetCapacity(new_len); > + effects->mFilters.SetLengthAndRetainStorage(new_len); I *think* `SetLength()` just does the right thing here? No need to `SetCapacity` and then `SetLength` ::: servo/components/style/properties/gecko.mako.rs:1464 (Diff revision 1) > + > + fn fill_filter(m_type: u32, value: CoordDataValue, gecko_filter: &mut nsStyleFilter){ > + gecko_filter.mType = m_type; > + let mut coord = nsStyleCoord::null(); > + coord.set_value(value); > + gecko_filter.mFilterParameter.copy_from(&coord); Why not `gecko_filter.mFilterParameter.set_value(value)`?
Attachment #8801000 -
Flags: review?(manishearth) → review+
Assignee | ||
Comment 4•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8801002 -
Attachment description: cat photo → cat photo (firefox)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•8 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecf9d5f8f5487f835a598be163378ad7b88b9cc8
Comment hidden (mozreview-request) |
Assignee | ||
Comment 8•8 years ago
|
||
Servo side patch: https://github.com/servo/servo/pull/13795
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by manishearth@gmail.com: https://hg.mozilla.org/integration/autoland/rev/60f9486949af Implement Stylo CSS filter except url and drop-shadow. r=manishearth
Keywords: checkin-needed
Comment 10•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/60f9486949af
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Updated•7 years ago
|
Blocks: stylo-nightly
You need to log in
before you can comment on or make changes to this bug.
Description
•