1310117 - Stylo: implement filter

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Shing Lyu [:shinglyu]]

Implement CSS Filters except url (blocked) and drop-shadow (difficult)

Comment 1

[Shing Lyu [:shinglyu]]

Attachment: Bug 1310117 - Implement Stylo CSS filter except url and drop-shadow.

r?manishearth

Review commit: https://reviewboard.mozilla.org/r/85800/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/85800/

Comment 2

[Shing Lyu [:shinglyu]]

Attachment: cat photo (firefox)

Filters in action.

Comment 3

[Manish Goregaokar [:manishearth]]

Comment on attachment 8801000 [details]
Bug 1310117 - Implement Stylo CSS filter except url and drop-shadow.

https://reviewboard.mozilla.org/r/85800/#review84442

Overall lgtm. Do you intend to add shadow support in this bug?

::: layout/style/ServoBindings.cpp:853
(Diff revision 1)
> +void
> +Gecko_ResetFilters(nsStyleEffects* effects, size_t new_len)
> +{
> +  effects->mFilters.Clear();
> +  effects->mFilters.SetCapacity(new_len);
> +  effects->mFilters.SetLengthAndRetainStorage(new_len);

I *think* `SetLength()` just does the right thing here? No need to `SetCapacity` and then `SetLength`

::: servo/components/style/properties/gecko.mako.rs:1464
(Diff revision 1)
> +
> +        fn fill_filter(m_type: u32, value: CoordDataValue, gecko_filter: &mut nsStyleFilter){
> +            gecko_filter.mType = m_type;
> +            let mut coord = nsStyleCoord::null();
> +            coord.set_value(value);
> +            gecko_filter.mFilterParameter.copy_from(&coord);

Why not `gecko_filter.mFilterParameter.set_value(value)`?

Comment 4

[Shing Lyu [:shinglyu]]

Attachment: cat photo (stylo)

Comment 5

[Shing Lyu [:shinglyu]]

Comment on attachment 8801000 [details]
Bug 1310117 - Implement Stylo CSS filter except url and drop-shadow.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/85800/diff/1-2/

Comment 6

[Shing Lyu [:shinglyu]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecf9d5f8f5487f835a598be163378ad7b88b9cc8

Comment 7

[Shing Lyu [:shinglyu]]

Comment on attachment 8801000 [details]
Bug 1310117 - Implement Stylo CSS filter except url and drop-shadow.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/85800/diff/2-3/

Comment 8

[Shing Lyu [:shinglyu]]

Servo side patch: https://github.com/servo/servo/pull/13795

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60f9486949af
Implement Stylo CSS filter except url and drop-shadow. r=manishearth

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/60f9486949af