Closed Bug 1310120 Opened 3 years ago Closed 3 years ago

puppet reinstalls scriptworker on every run

Categories

(Release Engineering :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rail, Assigned: aki)

Details

Attachments

(1 file)

... and restarts it. I discovered this while I was looking at the signing worker logs in papertrail. Additionally, signing-linux-1 generated ~1.3M events vs ~20K generated by others. Probably related to the initial setup?


Oct 14 00:57:01 signing-linux-1.srv.releng.use1.mozilla.com CROND: (root) CMD (. /usr/local/bin/proxy_reset_env.sh && /usr/bin/puppet agent --enable >/dev/null 2>/dev/null && /usr/bin/puppet agent --onetime --no-daemonize --logdest=syslog >/dev/null 2>&1)
Oct 14 00:57:01 signing-linux-1.srv.releng.use1.mozilla.com puppet-agent: Enabling Puppet.
Oct 14 00:57:40 signing-linux-1.srv.releng.use1.mozilla.com crontab: (root) LIST (root)
Oct 14 00:57:47 signing-linux-1.srv.releng.use1.mozilla.com puppet-agent: (/Stage[main]/Signing_scriptworker/Python35::Virtualenv[/builds/scriptworker]/Python35::Virtualenv::Package[/builds/scriptworker||frozendict==1.0]/Exec[pip /builds/scriptworker||frozendict==1.0]/returns) executed successfully


...


Oct 14 00:57:57 signing-linux-1.srv.releng.use1.mozilla.com puppet-agent: (/Stage[main]/Signing_scriptworker/Python35::Virtualenv[/builds/scriptworker]/Python35::Virtualenv::Package[/builds/scriptworker||slugid==1.0.7]/Exec[pip /builds/scriptworker||slugid==1.0.7]/returns) executed successfully
Oct 14 00:58:00 signing-linux-1.srv.releng.use1.mozilla.com puppet-agent: (/Stage[main]/Signing_scriptworker::Services/Exec[restart-scriptworker]) Triggered 'refresh' from 1 events
Oct 14 00:58:01 signing-linux-1.srv.releng.use1.mozilla.com puppet-agent: Finished catalog run in 28.40 seconds
re: 1.3m vs 20k, I've been using signing-linux-1 as my debugging ground since signing scriptworker isn't tier1 yet, and it's been alive for longer.  Unless you mean that's within the last week or 24hrs or something.

However, reinstalling scriptworker every run is wrong, and should be fixed.
Assignee: nobody → aki
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Attached patch puppetfixSplinter Review
Use the python3-compatible version of pip-check in the python35 module.
Attachment #8801933 - Flags: review?(mtabara)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #8801933 - Flags: review?(mtabara) → review+
(In reply to Aki Sasaki [:aki] from comment #3)
> Created attachment 8801933 [details] [diff] [review]
> puppetfix
> 
> Use the python3-compatible version of pip-check in the python35 module.

Just to confirm, the fix is working great ;) 

I was working on my beetmover puppet patches this morning and hit this problem as the python pip check would not install any dep packages in my virtualenv. After tweaking on my local environment with Aki's patch, it worked like a charm.
https://hg.mozilla.org/build/puppet/rev/cf679eab495015b386ce803b0f3b69faa7244cf3
bug 1310120 - use the py3 compatible pip_check in py35 virtualenv. r=mtabara
Awesome.  Fix is rolled out!
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.