puppet reinstalls scriptworker on every run

RESOLVED FIXED

Status

Release Engineering
General Automation
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: rail, Assigned: aki)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 months ago
... and restarts it. I discovered this while I was looking at the signing worker logs in papertrail. Additionally, signing-linux-1 generated ~1.3M events vs ~20K generated by others. Probably related to the initial setup?


Oct 14 00:57:01 signing-linux-1.srv.releng.use1.mozilla.com CROND: (root) CMD (. /usr/local/bin/proxy_reset_env.sh && /usr/bin/puppet agent --enable >/dev/null 2>/dev/null && /usr/bin/puppet agent --onetime --no-daemonize --logdest=syslog >/dev/null 2>&1)
Oct 14 00:57:01 signing-linux-1.srv.releng.use1.mozilla.com puppet-agent: Enabling Puppet.
Oct 14 00:57:40 signing-linux-1.srv.releng.use1.mozilla.com crontab: (root) LIST (root)
Oct 14 00:57:47 signing-linux-1.srv.releng.use1.mozilla.com puppet-agent: (/Stage[main]/Signing_scriptworker/Python35::Virtualenv[/builds/scriptworker]/Python35::Virtualenv::Package[/builds/scriptworker||frozendict==1.0]/Exec[pip /builds/scriptworker||frozendict==1.0]/returns) executed successfully


...


Oct 14 00:57:57 signing-linux-1.srv.releng.use1.mozilla.com puppet-agent: (/Stage[main]/Signing_scriptworker/Python35::Virtualenv[/builds/scriptworker]/Python35::Virtualenv::Package[/builds/scriptworker||slugid==1.0.7]/Exec[pip /builds/scriptworker||slugid==1.0.7]/returns) executed successfully
Oct 14 00:58:00 signing-linux-1.srv.releng.use1.mozilla.com puppet-agent: (/Stage[main]/Signing_scriptworker::Services/Exec[restart-scriptworker]) Triggered 'refresh' from 1 events
Oct 14 00:58:01 signing-linux-1.srv.releng.use1.mozilla.com puppet-agent: Finished catalog run in 28.40 seconds
(Assignee)

Comment 1

8 months ago
re: 1.3m vs 20k, I've been using signing-linux-1 as my debugging ground since signing scriptworker isn't tier1 yet, and it's been alive for longer.  Unless you mean that's within the last week or 24hrs or something.

However, reinstalling scriptworker every run is wrong, and should be fixed.
(Assignee)

Updated

8 months ago
Assignee: nobody → aki
(Assignee)

Comment 2

8 months ago
https://hg.mozilla.org/build/puppet/rev/7d6f218c25e1b688b2997ee853de1e050900c178
bug 1310120 - puppet reinstalls scriptworker on every run. r=rail
(Assignee)

Updated

8 months ago
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
(Assignee)

Comment 3

8 months ago
Created attachment 8801933 [details] [diff] [review]
puppetfix

Use the python3-compatible version of pip-check in the python35 module.
Attachment #8801933 - Flags: review?(mtabara)
(Assignee)

Updated

8 months ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #8801933 - Flags: review?(mtabara) → review+
(In reply to Aki Sasaki [:aki] from comment #3)
> Created attachment 8801933 [details] [diff] [review]
> puppetfix
> 
> Use the python3-compatible version of pip-check in the python35 module.

Just to confirm, the fix is working great ;) 

I was working on my beetmover puppet patches this morning and hit this problem as the python pip check would not install any dep packages in my virtualenv. After tweaking on my local environment with Aki's patch, it worked like a charm.
(Assignee)

Comment 5

8 months ago
https://hg.mozilla.org/build/puppet/rev/cf679eab495015b386ce803b0f3b69faa7244cf3
bug 1310120 - use the py3 compatible pip_check in py35 virtualenv. r=mtabara
(Assignee)

Comment 6

8 months ago
Awesome.  Fix is rolled out!
Status: REOPENED → RESOLVED
Last Resolved: 8 months ago8 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.