1310144 - The theme API should be able to support as much of Google Chrome themes as possible

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Mike de Boer [:mikedeboer]]

I've started a mapping of Google Chrome theme properties to Firefox theme variables at https://docs.google.com/a/mozilla.com/spreadsheets/d/1YScpOVL5WdNDhQY2Nngh4YkK0bOpkfwJvpRjpMSxMWo/edit?usp=sharing

The goal of this bug is to implement the latest state of the mapping in our theme manifest, translate them to CSS variables that are supported by Fx themes and used by our DevEdition theme.
Extending Firefox with more variables would be good fodder for a follow-up.

Comment 1

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1310144 - add support for an initial mapping of Chrome theme manifest properties, including a test manifest that uses DevEdition colors.

Review commit: https://reviewboard.mozilla.org/r/86612/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/86612/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8802063 [details]
Bug 1310144 - add support for an initial mapping of Chrome theme manifest properties, including a test manifest that uses DevEdition colors.

https://reviewboard.mozilla.org/r/86612/#review86612

::: browser/components/extensions/ext-theme.js:173
(Diff revision 1)
> -    if (LWTStyles.headerURL) {
> -      Services.obs.notifyObservers(null, "lightweight-theme-styling-update", JSON.stringify(LWTStyles));
> +    if (!LWTStyles.headerURL) {
> +      LWTStyles.headerURL = kTransparentGif;

Why is this hack necessary? Is it because we would need to trigger :moz-lwtheme, etc? Could we just change the lwtheme implementation to not need this type of hack?

Comment 3

[Mike de Boer [:mikedeboer]]

(In reply to [Limited availability until Oct 31] Jared Wein [:jaws] (please needinfo? me) from comment #2)
> Why is this hack necessary? Is it because we would need to trigger
> :moz-lwtheme, etc? Could we just change the lwtheme implementation to not
> need this type of hack?

Yup. I'm not really keen about changing up things there for the moment, if we don't really need to, and keep things contained in our little subdir.

Comment 4

[Mike de Boer [:mikedeboer]]

Comment on attachment 8802063 [details]
Bug 1310144 - add support for an initial mapping of Chrome theme manifest properties, including a test manifest that uses DevEdition colors.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/86612/diff/1-2/

Comment 5

[Mike de Boer [:mikedeboer]]

https://hg.mozilla.org/projects/cedar/rev/6c100129f6f75824d3f40c83873bd5114c130597
Bug 1310144 - add support for an initial mapping of Chrome theme manifest properties, including a test manifest that uses DevEdition colors. r=jaws