Closed Bug 1310144 Opened 4 years ago Closed 4 years ago

The theme API should be able to support as much of Google Chrome themes as possible

Categories

(WebExtensions :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mikedeboer, Assigned: mikedeboer)

References

Details

(Whiteboard: triaged)

Attachments

(1 file)

I've started a mapping of Google Chrome theme properties to Firefox theme variables at https://docs.google.com/a/mozilla.com/spreadsheets/d/1YScpOVL5WdNDhQY2Nngh4YkK0bOpkfwJvpRjpMSxMWo/edit?usp=sharing

The goal of this bug is to implement the latest state of the mapping in our theme manifest, translate them to CSS variables that are supported by Fx themes and used by our DevEdition theme.
Extending Firefox with more variables would be good fodder for a follow-up.
Blocks: 1311352
Comment on attachment 8802063 [details]
Bug 1310144 - add support for an initial mapping of Chrome theme manifest properties, including a test manifest that uses DevEdition colors.

https://reviewboard.mozilla.org/r/86612/#review86612

::: browser/components/extensions/ext-theme.js:173
(Diff revision 1)
> -    if (LWTStyles.headerURL) {
> -      Services.obs.notifyObservers(null, "lightweight-theme-styling-update", JSON.stringify(LWTStyles));
> +    if (!LWTStyles.headerURL) {
> +      LWTStyles.headerURL = kTransparentGif;

Why is this hack necessary? Is it because we would need to trigger :moz-lwtheme, etc? Could we just change the lwtheme implementation to not need this type of hack?
Attachment #8802063 - Flags: review?(jaws) → review+
(In reply to [Limited availability until Oct 31] Jared Wein [:jaws] (please needinfo? me) from comment #2)
> Why is this hack necessary? Is it because we would need to trigger
> :moz-lwtheme, etc? Could we just change the lwtheme implementation to not
> need this type of hack?

Yup. I'm not really keen about changing up things there for the moment, if we don't really need to, and keep things contained in our little subdir.
https://hg.mozilla.org/projects/cedar/rev/6c100129f6f75824d3f40c83873bd5114c130597
Bug 1310144 - add support for an initial mapping of Chrome theme manifest properties, including a test manifest that uses DevEdition colors. r=jaws
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.