Closed Bug 1310205 Opened 8 years ago Closed 8 years ago

MOZ_ASSERT(entry->mRec->mFrecency == 0 ||

Categories

(Core :: Networking: Cache, defect)

Product:
Core
Component:
Networking: Cache
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: jya, Assigned: michal)

References

(
URL
)

Details

(Whiteboard: [necko-active])

Attachments

(1 file)

fix
1.77 KB, patch
mayhemer
: review+
Details | Diff | Splinter Review 
Twice attempting to open this URL I got an assert:
Thread 25 "Cache2 I/O" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffd2149700 (LWP 18471)]
0x00007fffe37ac136 in mozilla::net::CacheIndexEntryAutoManage::~CacheIndexEntryAutoManage (this=0x7fffd2148b40) at /home/jyavenard/Work/Mozilla/mozilla-central/netwerk/cache2/CacheIndex.cpp:138
138	        MOZ_ASSERT(entry->mRec->mFrecency == 0 ||
[Thread 0x7fffb40fd700 (LWP 18509) exited]


entry->mRec->mFrecency is 1023397337
and mOldFrecency is 1023398377
Actually, it's now happening all the time, whenever I restart :(
Michal, can you take a look please?

Jean-Yves, on what revision are you?
Assignee: nobody → michal.novotny
Flags: needinfo?(michal.novotny)
Flags: needinfo?(jyavenard)
Whiteboard: [necko-active]
I'm on central, local debug build. Pulled last night.

Re-pulling again now to see if anything changes.
Flags: needinfo?(jyavenard)
nope, same deal... I thought I could try fixing thing by cleaning the cache, but I'm never quick enough to go into the advanced preferences to clean the cache.
(In reply to Jean-Yves Avenard [:jya] from comment #4)
> nope, same deal... I thought I could try fixing thing by cleaning the cache,
> but I'm never quick enough to go into the advanced preferences to clean the
> cache.

Please don't!  Please save the profile, including the "local" part that holds the cache (/cache2 dir with /entries and /doomed sub-dirs), so we have a way to reproduce this issue.  I think deleting the cache2 dir will make this go away, but having a whole profile backed up is the best way to do at this stage.

Thanks!
By "save the profile" I simply mean "make a backup" :)
Which file in particular do you need from the profile, or do you need the whole lot?

I have my firefox account work credentials set there... so would prefer a way to not having to share that.
(In reply to Jean-Yves Avenard [:jya] from comment #7)
> Which file in particular do you need from the profile, or do you need the
> whole lot?
> 
> I have my firefox account work credentials set there... so would prefer a
> way to not having to share that.

I think the most important files are cache2/index.*.  Where exactly the cache files are can be found easily in about:cache.

Best (to be on the safe side) would be to backup the whole cache2 directory, but depends on your free space availability.  The index files should be sufficient, tho.
there's no cache2 directory in the profile folder.

find .
.
./bookmarkbackups
./bookmarkbackups/bookmarks-2016-07-23_13_TCSce1jhG-O1asKr3NqX5Q==.jsonlz4
./bookmarkbackups/bookmarks-2016-08-08_70_N0OUfbSO-+Bc3UMmNhW4HQ==.jsonlz4
./bookmarkbackups/bookmarks-2016-09-09_71_ycv3IDhZZjeZUjvNNM2grQ==.jsonlz4
./bookmarkbackups/bookmarks-2016-09-12_71_6lcE--fi9daD+WQCi4BNGw==.jsonlz4
./bookmarkbackups/bookmarks-2016-09-21_79_zy7ld8d7PunouNxdU6JzOg==.jsonlz4
./bookmarkbackups/bookmarks-2016-10-14_83_HdG3OnxhW5TtlrILAg7gyA==.jsonlz4
./crashes
./crashes/events
./crashes/store.json.mozlz4
./datareporting
./datareporting/archived
./datareporting/archived/2016-09
./datareporting/archived/2016-09/1472974764941.c3b14c78-df63-4e30-a90e-a34d81d7efb7.main.jsonlz4
./datareporting/archived/2016-09/1472986096287.677d99e5-43c2-4c34-827c-9c68098457e3.main.jsonlz4
./datareporting/archived/2016-09/1472986617570.2344bc27-9dc0-47fc-a3da-265be1eda92a.main.jsonlz4
./datareporting/archived/2016-09/1472987532151.4d9d6a2a-8b85-4fd6-b0b9-214a8dc85b3c.main.jsonlz4
./datareporting/archived/2016-09/1473030505857.d64e8f54-01c6-40dc-9aca-d6bc9214820f.main.jsonlz4
./datareporting/archived/2016-09/1473033446267.5768bad1-64dd-4b4c-99d0-cfc541abd543.main.jsonlz4
./datareporting/archived/2016-09/1473035108377.db4995b1-e7b2-4862-89d8-a0aded684b58.main.jsonlz4
./datareporting/archived/2016-09/1473040959412.9caee911-9e1c-440d-9247-1ff36413004b.main.jsonlz4
./datareporting/archived/2016-09/1473041424472.ee8dda67-100e-4bc1-b149-9ace9f3ce5eb.main.jsonlz4
./datareporting/archived/2016-09/1473252270078.b8e3621e-f7c9-478a-98c8-92a0b914443c.main.jsonlz4
./datareporting/archived/2016-09/1473341587038.86e79746-6269-4312-a691-ee3442da1f1d.main.jsonlz4
./datareporting/archived/2016-09/1473343163897.562b01b5-b2c8-4501-bc7d-aaad393c80e7.main.jsonlz4
./datareporting/archived/2016-09/1473348335884.c658e03b-682b-49fc-a569-f73304ab97cb.main.jsonlz4
./datareporting/archived/2016-09/1473409599572.e493be38-432a-4fc7-bd9c-9af85e7ebe6d.main.jsonlz4
./datareporting/archived/2016-09/1473664938759.eddd6176-5507-42d4-9faa-e8657595118c.main.jsonlz4
./datareporting/archived/2016-09/1473686566935.2e3c75c4-0470-4fde-8f55-625efceff199.main.jsonlz4
./datareporting/archived/2016-09/1474081453867.2db466e1-bf6d-4885-9680-e9162fce851e.main.jsonlz4
./datareporting/archived/2016-09/1474081657579.c3641580-df40-4de6-9209-57d647ac28c6.sync.jsonlz4
./datareporting/archived/2016-09/1474081658644.f6d83a8c-4179-42ac-ba55-a12fe4d0b93f.main.jsonlz4
./datareporting/archived/2016-09/1474082366754.df0e6ea6-9e03-4644-b069-660efd080680.main.jsonlz4
./datareporting/archived/2016-09/1474193691797.17120f1a-1873-4a26-999f-db5f6e9c1195.main.jsonlz4
./datareporting/archived/2016-09/1474203354643.7514a4a8-7b24-42d7-89d1-18da22f0e010.main.jsonlz4
./datareporting/archived/2016-09/1474253057928.56e68981-885c-47a0-acda-0bad64a23550.main.jsonlz4
./datareporting/archived/2016-09/1474253276327.623723c3-593d-44e7-8ddf-c941a5facc7b.main.jsonlz4
./datareporting/archived/2016-09/1474254680627.3d920b2c-749f-4442-ae3b-921c1193e54a.main.jsonlz4
./datareporting/archived/2016-09/1474254980689.42cfcc9b-b64d-43e8-8724-320258c1fe84.main.jsonlz4
./datareporting/archived/2016-09/1474261512869.97623dac-4228-45e1-9b9f-0f0f4dbd6dd3.main.jsonlz4
./datareporting/archived/2016-09/1474265693959.0e8411a3-24e8-4a0f-8f67-1b8303fe0eff.main.jsonlz4
./datareporting/archived/2016-09/1474454869659.4b9e7714-b927-4e97-b6af-396a69aad53a.main.jsonlz4
./datareporting/archived/2016-09/1474454878934.155fb400-d038-4974-97f7-cf91f5a89d58.sync.jsonlz4
./datareporting/archived/2016-09/1474454880288.d15a8481-1a02-4c5a-8e27-5375899ca447.main.jsonlz4
./datareporting/archived/2016-09/1474454978349.8d1364c8-df97-4f4c-b064-8cef48762a3a.main.jsonlz4
./datareporting/archived/2016-09/1474455391668.28e477ac-3ec2-4d06-8fa5-4e7140525984.main.jsonlz4
./datareporting/archived/2016-09/1474455399923.5455f156-9b43-4969-8b5c-d2ba435bd732.sync.jsonlz4
./datareporting/archived/2016-09/1474455400766.c888d8a9-8185-4779-9a31-5a3ffd1722f0.main.jsonlz4
./datareporting/archived/2016-09/1474457045371.224154c1-533d-4b01-a62e-3fb59e1797a4.main.jsonlz4
./datareporting/archived/2016-09/1474607516974.3db104f2-28c7-46ff-a0e8-1bb780f6667c.main.jsonlz4
./datareporting/archived/2016-09/1474711030187.9eacf6cd-0817-46e3-9398-38c07a47280d.main.jsonlz4
./datareporting/archived/2016-09/1474712492493.112806bb-9bac-4527-a26b-b56b962ba044.main.jsonlz4
./datareporting/archived/2016-09/1474787755387.7b9accf8-3e41-4afc-8c49-4b39efd339b0.main.jsonlz4
./datareporting/archived/2016-09/1474792680290.7a83c31c-9bb1-45b8-8f20-a07a7ec6d459.main.jsonlz4
./datareporting/archived/2016-09/1474798375547.e96c591a-ad61-41de-af8e-172429849816.main.jsonlz4
./datareporting/archived/2016-09/1474803649489.fe8bc2af-58ba-4370-bf45-ac9667cc62c7.main.jsonlz4
./datareporting/archived/2016-09/1474809534265.0fd1245a-005b-4fee-aaef-6a1cf269d871.main.jsonlz4
./datareporting/archived/2016-10
./datareporting/archived/2016-10/1476119084515.414f70c9-ae67-48ce-84f2-9cf1186e454f.main.jsonlz4
./datareporting/archived/2016-10/1476119383543.175c079b-27d8-449a-b519-d5f32858cc2b.sync.jsonlz4
./datareporting/archived/2016-10/1476119384902.0d0fad54-23f9-409e-9d18-9ec274a5fe96.main.jsonlz4
./datareporting/archived/2016-10/1476343268327.d99f7dc4-a7cc-48c2-97b1-bfea1d4fe7dc.main.jsonlz4
./datareporting/archived/2016-10/1476447652299.42df28d7-494d-40e0-af1f-de6882732dab.main.jsonlz4
./datareporting/archived/2016-10/1476449336411.32420d4d-401e-40e9-9a7e-a8e41242d21c.main.jsonlz4
./datareporting/archived/2016-10/1476449736103.d574d093-e4a5-492d-ad5e-b13e27069f2a.main.jsonlz4
./datareporting/state.json
./datareporting/session-state.json
./datareporting/aborted-session-ping
./extensions
./extensions/jid1-kyxEAcWua7BEKq@jetpack.xpi
./extensions/aboutmedia@gavinsharp.com.xpi
./gmp-gmpopenh264
./gmp-gmpopenh264/1.6
./gmp-gmpopenh264/1.6/libgmpopenh264.so
./gmp-gmpopenh264/1.6/gmpopenh264.info
./gmp
./gmp/Linux_x86_64-gcc3
./gmp/Linux_x86_64-gcc3/gmp-clearkey
./gmp/Linux_x86_64-gcc3/gmp-clearkey/id
./gmp/Linux_x86_64-gcc3/gmp-clearkey/id/1875624408
./gmp/Linux_x86_64-gcc3/gmp-clearkey/id/1875624408/salt
./gmp/Linux_x86_64-gcc3/gmp-clearkey/id/1875624408/origin
./gmp/Linux_x86_64-gcc3/gmp-clearkey/id/1875624408/topLevelOrigin
./gmp/Linux_x86_64-gcc3/gmp-clearkey/storage
./gmp/Linux_x86_64-gcc3/gmp-clearkey/storage/fHa6rElX_lNQ9leIGYg_pb8ON1JjWokL
./minidumps
./saved-telemetry-pings
./saved-telemetry-pings/989929c7-8158-430d-b3e8-df2ce219beaf
./saved-telemetry-pings/a5d02697-cef7-4f57-a0b7-68b32e60156d
./saved-telemetry-pings/d7877f33-1fee-4c8d-82a2-bac9fd42f3a7
./saved-telemetry-pings/3d1e9c52-8349-4f6e-a4f9-ade72990e8f9
./saved-telemetry-pings/97ad1b12-1e4e-4bdd-9314-d14b8f11181b
./saved-telemetry-pings/daa53ae6-f591-4ba8-b79f-6ef65a61b0e9
./saved-telemetry-pings/2baec359-d75e-4e42-bd3d-b49dd7cf9dab
./saved-telemetry-pings/9b783fd9-befa-4b3e-8ff2-97c639f9fd39
./saved-telemetry-pings/35d5e3ea-cbe0-4e03-a608-3806f9bbf5ce
./saved-telemetry-pings/1253a524-4d74-4665-b5de-3b574caecce5
./saved-telemetry-pings/923f7db3-8287-412d-9604-c1c3e835abb1
./saved-telemetry-pings/77e1ec3a-3353-4aa0-8f78-c9e8589cca5b
./saved-telemetry-pings/16e78d76-c1f7-4f32-ba3f-1d9bf3742566
./saved-telemetry-pings/eb39e62f-8600-4d21-bb86-18bb725fd19e
./saved-telemetry-pings/4aa4ddba-8ef2-4dfc-a8ac-c48082f48ca2
./saved-telemetry-pings/54b4b79b-6892-4464-9a5b-cf543b2a6093
./saved-telemetry-pings/9fb70f6d-e8f6-4c82-b81f-4185e968005b
./saved-telemetry-pings/0e48c65f-40da-425e-8e56-1c1078172e7f
./saved-telemetry-pings/f547b9f6-2b1d-4f68-a250-058b9af39d35
./saved-telemetry-pings/2756d49c-a880-44b5-b71c-75d76c6fe9d6
./saved-telemetry-pings/59535a72-d1a4-431e-b05e-b32ab5debfb2
./saved-telemetry-pings/382d6999-ef7e-471a-b8ed-83f489742ef5
./saved-telemetry-pings/91438769-ef03-4833-badb-132df08cc3d9
./saved-telemetry-pings/e535a763-be2a-495a-82a4-58460245abec
./saved-telemetry-pings/37493489-ca68-49fe-a2b5-3c9b29a4cb93
./saved-telemetry-pings/fa9e0c12-d7e1-4766-80fc-68a454c1a080
./saved-telemetry-pings/bea1e52d-ff4c-442c-beb7-4286b785b99c
./saved-telemetry-pings/42a1c879-871e-4843-b33c-cdce0605e45e
./saved-telemetry-pings/157301f2-4d4c-4604-807a-75a370ae24ee
./saved-telemetry-pings/09ab5d49-9518-4c75-aa68-96edc75f22af
./saved-telemetry-pings/c2785e38-3514-4920-9913-f6a43055232f
./saved-telemetry-pings/b3937b3b-cf6f-4931-a122-4f1c4684debd
./saved-telemetry-pings/86d65832-00d6-47f7-a0a8-b27432b80307
./saved-telemetry-pings/41a6582e-ebf2-484a-a696-ce149bb7f2f6
./saved-telemetry-pings/3b69d296-f1db-44da-8f94-c95b6c8055b6
./saved-telemetry-pings/610f1062-9770-4d91-8824-889cfad3f7f6
./saved-telemetry-pings/f637921c-d582-4602-9df6-2cf5a2aa7fa0
./saved-telemetry-pings/e17eaae9-bed2-4538-a9e9-28f5383b856d
./saved-telemetry-pings/4af88373-04d6-4d07-be93-f11729afab9a
./saved-telemetry-pings/5324517e-f081-452b-974d-2bc1f8cb290a
./saved-telemetry-pings/d930a6b4-c6dc-4b24-9a59-a7f62db84b86
./saved-telemetry-pings/d63f47a7-110f-4cd0-b758-c018b903a8b5
./saved-telemetry-pings/82bfe161-c594-410d-8fd3-1177f445c87c
./saved-telemetry-pings/c2844542-690f-42c3-8ba6-0f9012666d48
./saved-telemetry-pings/33723f7d-ae59-4e01-b3f7-2c5e931eb66d
./saved-telemetry-pings/30989f8b-0325-49d3-aee7-4dc301693a09
./saved-telemetry-pings/c3b14c78-df63-4e30-a90e-a34d81d7efb7
./saved-telemetry-pings/677d99e5-43c2-4c34-827c-9c68098457e3
./saved-telemetry-pings/2344bc27-9dc0-47fc-a3da-265be1eda92a
./saved-telemetry-pings/4d9d6a2a-8b85-4fd6-b0b9-214a8dc85b3c
./saved-telemetry-pings/d64e8f54-01c6-40dc-9aca-d6bc9214820f
./saved-telemetry-pings/5768bad1-64dd-4b4c-99d0-cfc541abd543
./saved-telemetry-pings/db4995b1-e7b2-4862-89d8-a0aded684b58
./saved-telemetry-pings/9caee911-9e1c-440d-9247-1ff36413004b
./saved-telemetry-pings/ee8dda67-100e-4bc1-b149-9ace9f3ce5eb
./saved-telemetry-pings/b8e3621e-f7c9-478a-98c8-92a0b914443c
./saved-telemetry-pings/562b01b5-b2c8-4501-bc7d-aaad393c80e7
./saved-telemetry-pings/c658e03b-682b-49fc-a569-f73304ab97cb
./saved-telemetry-pings/e493be38-432a-4fc7-bd9c-9af85e7ebe6d
./saved-telemetry-pings/eddd6176-5507-42d4-9faa-e8657595118c
./saved-telemetry-pings/2e3c75c4-0470-4fde-8f55-625efceff199
./saved-telemetry-pings/df0e6ea6-9e03-4644-b069-660efd080680
./saved-telemetry-pings/7514a4a8-7b24-42d7-89d1-18da22f0e010
./saved-telemetry-pings/56e68981-885c-47a0-acda-0bad64a23550
./saved-telemetry-pings/42cfcc9b-b64d-43e8-8724-320258c1fe84
./saved-telemetry-pings/0e8411a3-24e8-4a0f-8f67-1b8303fe0eff
./saved-telemetry-pings/224154c1-533d-4b01-a62e-3fb59e1797a4
./saved-telemetry-pings/3db104f2-28c7-46ff-a0e8-1bb780f6667c
./saved-telemetry-pings/9eacf6cd-0817-46e3-9398-38c07a47280d
./saved-telemetry-pings/112806bb-9bac-4527-a26b-b56b962ba044
./saved-telemetry-pings/7a83c31c-9bb1-45b8-8f20-a07a7ec6d459
./saved-telemetry-pings/e96c591a-ad61-41de-af8e-172429849816
./saved-telemetry-pings/fe8bc2af-58ba-4370-bf45-ac9667cc62c7
./saved-telemetry-pings/0fd1245a-005b-4fee-aaef-6a1cf269d871
./saved-telemetry-pings/d99f7dc4-a7cc-48c2-97b1-bfea1d4fe7dc
./saved-telemetry-pings/42df28d7-494d-40e0-af1f-de6882732dab
./saved-telemetry-pings/32420d4d-401e-40e9-9a7e-a8e41242d21c
./saved-telemetry-pings/d574d093-e4a5-492d-ad5e-b13e27069f2a
./sessionstore-backups
./sessionstore-backups/upgrade.js-20160917121047
./sessionstore-backups/upgrade.js-20160921190235
./sessionstore-backups/previous.js
./sessionstore-backups/upgrade.js-20161013180245
./sessionstore-backups/recovery.bak
./sessionstore-backups/recovery.js
./storage
./storage/default
./storage/default/https+++www.amazon.com
./storage/default/https+++www.amazon.com/.metadata
./storage/default/https+++www.amazon.com/.metadata-v2
./storage/default/https+++www.amazon.com/idb
./storage/default/https+++www.amazon.com/idb/2153786202SecrroitpSt.sqlite
./storage/default/https+++www.amazon.com/idb/2153786202SecrroitpSt.files
./storage/permanent
./storage/permanent/chrome
./storage/permanent/chrome/idb
./storage/permanent/chrome/idb/2918063365piupsah.files
./storage/permanent/chrome/idb/2918063365piupsah.sqlite
./storage/permanent/chrome/.metadata
./storage/permanent/chrome/.metadata-v2
./storage/permanent/indexeddb+++fx-devtools
./storage/permanent/indexeddb+++fx-devtools/idb
./storage/permanent/indexeddb+++fx-devtools/idb/478967115deegvatroootlss--cans.files
./storage/permanent/indexeddb+++fx-devtools/idb/478967115deegvatroootlss--cans.sqlite
./storage/permanent/indexeddb+++fx-devtools/.metadata
./storage/permanent/indexeddb+++fx-devtools/.metadata-v2
./storage/permanent/moz-safe-about+home
./storage/permanent/moz-safe-about+home/idb
./storage/permanent/moz-safe-about+home/idb/818200132aebmoouht.files
./storage/permanent/moz-safe-about+home/idb/818200132aebmoouht.sqlite
./storage/permanent/moz-safe-about+home/.metadata
./storage/permanent/moz-safe-about+home/.metadata-v2
./storage/temporary
./storage/temporary/http+++player.twitch.tv^userContextId=2147483647
./storage/temporary/http+++player.twitch.tv^userContextId=2147483647/asmjs
./storage/temporary/http+++player.twitch.tv^userContextId=2147483647/asmjs/metadata
./storage/temporary/http+++player.twitch.tv^userContextId=2147483647/asmjs/module15
./storage/temporary/http+++player.twitch.tv^userContextId=2147483647/.metadata
./storage/temporary/http+++player.twitch.tv^userContextId=2147483647/.metadata-v2
./storage/temporary/https+++player.twitch.tv^userContextId=5
./storage/temporary/https+++player.twitch.tv^userContextId=5/.metadata
./storage/temporary/https+++player.twitch.tv^userContextId=5/.metadata-v2
./storage/temporary/https+++player.twitch.tv^userContextId=5/asmjs
./storage/temporary/https+++player.twitch.tv^userContextId=5/asmjs/module15
./storage/temporary/https+++player.twitch.tv^userContextId=5/asmjs/metadata
./weave
./weave/changes
./weave/changes/tabs.json
./weave/changes/clients.json
./weave/changes/passwords.json
./weave/changes/bookmarks.json
./weave/changes/addons.json
./weave/changes/forms.json
./weave/changes/history.json
./weave/logs
./weave/logs/error-sync-1472649337673.txt
./weave/logs/error-sync-1472974722590.txt
./weave/logs/error-sync-1472976476837.txt
./weave/logs/error-sync-1472981013031.txt
./weave/logs/error-sync-1472982172004.txt
./weave/logs/error-sync-1472982772322.txt
./weave/logs/error-sync-1472983372507.txt
./weave/logs/error-sync-1472984178882.txt
./weave/logs/error-sync-1472984779269.txt
./weave/logs/error-sync-1472985379667.txt
./weave/logs/error-sync-1472985980085.txt
./weave/logs/error-sync-1472986575347.txt
./weave/logs/error-sync-1472987533074.txt
./weave/logs/error-sync-1473030136689.txt
./weave/logs/error-sync-1473030587937.txt
./weave/logs/error-sync-1473032766836.txt
./weave/logs/error-sync-1473033367261.txt
./weave/logs/error-sync-1473034767558.txt
./weave/logs/error-sync-1473035318167.txt
./weave/logs/error-sync-1473035918594.txt
./weave/logs/error-sync-1473036518789.txt
./weave/logs/error-sync-1473038356066.txt
./weave/logs/error-sync-1473040678897.txt
./weave/logs/error-sync-1473040960686.txt
./weave/logs/error-sync-1473041081184.txt
./weave/logs/error-sync-1473244731045.txt
./weave/logs/error-sync-1473251625472.txt
./weave/addonsreconciler.json
./webapps
./webapps/webapps.json
./.parentlock
./SiteSecurityServiceState.txt
./cert8.db
./compatibility.ini
./content-prefs.sqlite
./cookies.sqlite
./formhistory.sqlite
./key3.db
./kinto.sqlite
./mimeTypes.rdf
./permissions.sqlite
./places.sqlite
./secmod.db
./storage.sqlite
./times.json
./webappsstore.sqlite
./containers.json
./experiments.json
./gmp-widevinecdm
./gmp-widevinecdm/1.4.8.903
./gmp-widevinecdm/1.4.8.903/LICENSE.txt
./gmp-widevinecdm/1.4.8.903/libwidevinecdm.so
./gmp-widevinecdm/1.4.8.903/manifest.json
./AlternateServices.txt
./SecurityPreloadState.txt
./places.sqlite-wal
./places.sqlite-shm
./cookies.sqlite-wal
./cookies.sqlite-shm
./webappsstore.sqlite-wal
./webappsstore.sqlite-shm
./pluginreg.dat
./addons.json
./blocklist.xml
./blocklist-addons.json
./revocations.txt
./blocklist-plugins.json
./blocklist-gfx.json
./xulstore.json
./signedInUser.json
./logins.json
./prefs.js
./extensions.ini
./extensions.json
./sessionCheckpoints.json
./search.json.mozlz4
(In reply to Jean-Yves Avenard [:jya] from comment #9)
> there's no cache2 directory in the profile folder.

If you're on linux, the cache is in ~/.cache/mozilla/firefox/profile
(In reply to Honza Bambas (:mayhemer) from comment #2)
> Michal, can you take a look please?

Frecency is only updated here:

http://searchfox.org/mozilla-central/rev/d96317a351af8aa78ab9847e7feed964bbaac7d7/netwerk/cache2/CacheEntry.cpp#1815

Maybe my understanding of the algorithm is wrong, i.e. the number isn't only increasing (please check it, it's your code). Or the old frecency in metadata is different from what's in the index.

As an immediate fix, I'd remove the assertion because if it happens just occasionally then moving the entry at the end is still the best we can do here.
Flags: needinfo?(michal.novotny) → needinfo?(honzab.moz)
(In reply to Jean-Yves Avenard [:jya] from comment #9)
> there's no cache2 directory in the profile folder.

Go to about:cache page.  You will see the path under 'disk/Storage disk location'.
(In reply to Honza Bambas (:mayhemer) from comment #12)
> (In reply to Jean-Yves Avenard [:jya] from comment #9)
> > there's no cache2 directory in the profile folder.
> 
> Go to about:cache page.  You will see the path under 'disk/Storage disk
> location'.

That assumes it wouldn't crash before you get the chance of visiting any pages ...
I'm uploading ~/.cache/mozilla/firefox/

it will be available there:
https://people.mozilla.org/~jyavenard/4tbhrhy6.Development.tbz the file is 210MB so will take a while to complete uploading as I only have a 2Mbit/s uplink
(In reply to Jean-Yves Avenard [:jya] from comment #13)
> (In reply to Honza Bambas (:mayhemer) from comment #12)
> > (In reply to Jean-Yves Avenard [:jya] from comment #9)
> > > there's no cache2 directory in the profile folder.
> > 
> > Go to about:cache page.  You will see the path under 'disk/Storage disk
> > location'.
> 
> That assumes it wouldn't crash before you get the chance of visiting any
> pages ...

Ah!  Yes - sorry, I didn't realize that :D  


(In reply to Jean-Yves Avenard [:jya] from comment #14)
> I'm uploading ~/.cache/mozilla/firefox/
> 
> it will be available there:
> https://people.mozilla.org/~jyavenard/4tbhrhy6.Development.tbz the file is
> 210MB so will take a while to complete uploading as I only have a 2Mbit/s
> uplink

Thanks!  I can reproduce the assertion.
Flags: needinfo?(honzab.moz)
Could it happen that we update the index with new frecency but the entry file was not updated on disk because of shutdown write bypass?  That seems reasonable to me and I think we can then remove (or loosen) the assertion here.
Flags: needinfo?(michal.novotny)
What's a "frecency"?
Hmm.. the index file is older than the entry.  Looks like we updated the entry file, but failed to write that to the index somehow.  

Jean-Yves, did the browser recently crash for you or did you kill it before this assertion started to appear?  It could be the reason why index file has not been updated.

Anyway, I think we should remove the assertion altogether.  This is not fatal, apparently can "legally" happen and exactly this code is making the index data be updated to reflect the reality.

I re-checked the code and frecency is always moving forward.
Flags: needinfo?(jyavenard)
(In reply to Jean-Yves Avenard [:jya] from comment #17)
> What's a "frecency"?

https://en.wikipedia.org/wiki/Frecency
(In reply to Honza Bambas (:mayhemer) from comment #18)
> Hmm.. the index file is older than the entry.  Looks like we updated the
> entry file, but failed to write that to the index somehow.  
> 
> Jean-Yves, did the browser recently crash for you or did you kill it before
> this assertion started to appear?  It could be the reason why index file has
> not been updated.
> 

It's entirely possible..

This is used with my working build.

I could either crash, assert or simply be killed nastily..

However, I'm fairly confident that right prior the crash I actually shut down Firefox properly as I was playing with preferences, and with those unless you quit cleanly they aren't saved properly..
Flags: needinfo?(jyavenard)
Attached patch fix — — Splinter Review 
Flags: needinfo?(michal.novotny)

        Attachment #8801686 -
        Flags: review?(honzab.moz)

        Attachment #8801686 -
        Flags: review?(honzab.moz) → review+

    
    

    
  
Pushed by mnovotny@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/491e23f61d9e
remove MOZ_ASSERT(entry->mRec->mFrecency == 0 || entry->mRec->mFrecency > mOldFrecency)), r=honzab

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/491e23f61d9e
Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox52:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: