Closed Bug 1310237 Opened 5 years ago Closed 5 years ago

skip-if(!asyncZoom) reftests not getting run at all

Categories

(Testing :: Reftest, defect)

All
Android
defect
Not set
normal

Tracking

(firefox52 fixed)

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: kats, Assigned: kats)

Details

Attachments

(1 file)

Right now when running reftests we set apz.allow_zooming to false on Android [1]. Which means that the asyncZoom sandbox condition [2] is going to be false on Android. This sandbox condition is also false on desktop platforms, which means tests that are guarded by skip-if(!asyncZoom) are not get running anywhere. They used to run on B2G but that's been decomissioned already.

We should probably change those skip-if(!asyncZoom) conditions to pref(apz.allow_zooming,true) skip-if(!Android), and maybe get rid of the asyncZoom sandbox condition entirely.

[1] http://searchfox.org/mozilla-central/rev/d96317a351af8aa78ab9847e7feed964bbaac7d7/layout/tools/reftest/remotereftest.py#238
[2] http://searchfox.org/mozilla-central/rev/d96317a351af8aa78ab9847e7feed964bbaac7d7/layout/tools/reftest/reftest.jsm#751
I made the changes described above and updated the fuzziness values to match what they need to be to pass on Android.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=44c8e4fe2f52
Comment on attachment 8802749 [details]
Bug 1310237 - Change skip-if(!asyncZoom) tests to skip-if(!Android) with zooming enabled. Also update the fuzziness checks to match current Android reftest results.

https://reviewboard.mozilla.org/r/87046/#review86092
Attachment #8802749 - Flags: review?(tnikkel) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/313322c0bd15
Change skip-if(!asyncZoom) tests to skip-if(!Android) with zooming enabled. Also update the fuzziness checks to match current Android reftest results. r=tnikkel
https://hg.mozilla.org/mozilla-central/rev/313322c0bd15
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.