1310265 - Implement Paste & Go

Status: VERIFIED FIXED

(Focus-iOS :: General, defect, P2)

Description

[Brian Nicholson (:bnicholson)]

UI for going to the link on the clipboard. See https://mozilla.invisionapp.com/share/5F8YJSF3H#/screens/197040428_IPhone_7_-_Typing

Comment 1

[Barbara Bermes [:barbara] - NI please!]

Is this to help out with long URLs the user might not want to type in and because it's not in their history in Focus, they can easily get to it?

Comment 2

[Brian Nicholson (:bnicholson)]

I think so -- we have the share button for Focus -> Firefox/Safari, but we don't have any way to easily go the opposite direction.

More options:
* Adding Paste & Go when long-pressing the URL bar like Firefox/Safari
* Adding HTTP(S) scheme handlers so we show up in the system share sheets
* Adding a custom focus:// scheme handler so we can launch focus directly from browser UI (Firefox only)

Comment 3

[Brian Nicholson (:bnicholson)]

Sounds like we want to go with HTTP(S) scheme handlers as a first pass. We may decide to add others later.

Comment 4

[Brian Nicholson (:bnicholson)]

After more discussion, we're just going to go with Paste & Go for now.

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Does this have lower priority than iPad and Landscape support? If so, drop this for now?

Comment 6

[Barbara Bermes [:barbara] - NI please!]

iPad landscape has higher priority than this bug

Comment 7

[Bram Pitoyo [:bram]]

(In reply to Brian Nicholson (:bnicholson) from comment #2)
> * Adding Paste & Go when long-pressing the URL bar like Firefox/Safari

+1. This makes a lot of sense, and we should implement it.


> * Adding HTTP(S) scheme handlers so we show up in the system share sheets

This also makes sense.

If possible, the action has to be clear and can’t just be an icon with the word “Firefox Focus” below it. Instead, it should be something like “Open in Private Browsing” or “Open in Firefox Focus”. Or if it’s a highlighted text, our action should be “Private Search” or “Search in Firefox Focus”.


> * Adding a custom focus:// scheme handler so we can launch focus directly
> from browser UI (Firefox only)

I’ll have a think about this one. Can we think of a good use case for this custom scheme?

Comment 8

[Bram Pitoyo [:bram]]

Attachment: focus for android - typing active - i01

As antlam had suggested, in addition to a context menu that says “Paste & Go”, we’d also like to implement a shortcut to the clipboard, so you can access what’s in it instantly just by tapping on the URL bar.

My proposal adds two things to the original suggestion:

1. Instead of saying: “Copied: [url]”, we instead represent the clipboard with an icon.

2. If the thing that you copied is a set of words instead of a link, we’d like to provide a shortcut called “Search for [keyword]”.

Comment 9

[Bram Pitoyo [:bram]]

Attachment: focus for android - typing active (full suggestion) - i01

Over on Slack, Jessica Jiang wrote her concern about the persistent “Copied” area:

> …I would think that if the user has begun to type in a keyword, they wouldn’t
> need to access the link in clipboard anymore - this is the logic in Chrome
> mobile as well.)

My feedback is that the “Copied” area should always remain shown on the URL bar results, even after the user started typing.

However, we might very well offer search suggestions in the future. When this happens, the “Copied” area should always be positioned on the bottom of the results. This way, you can still get to what you’ve copied, but it’s not emphasised when there are more important keywords around.

How does this sound?

Comment 10

[:sdaswani]

(In reply to Bram Pitoyo [:bram] from comment #9)
> Created attachment 8875118 [details]
> focus for android - typing active (full suggestion) - i01
> 
> Over on Slack, Jessica Jiang wrote her concern about the persistent “Copied”
> area:
> 
> > …I would think that if the user has begun to type in a keyword, they wouldn’t
> > need to access the link in clipboard anymore - this is the logic in Chrome
> > mobile as well.)
> 
> My feedback is that the “Copied” area should always remain shown on the URL
> bar results, even after the user started typing.
> 
> However, we might very well offer search suggestions in the future. When
> this happens, the “Copied” area should always be positioned on the bottom of
> the results. This way, you can still get to what you’ve copied, but it’s not
> emphasised when there are more important keywords around.
> 
> How does this sound?

A couple of questions
1) I see the images [:bram] attached are titled 'focus for android...' - just to be clear that [:jjiang] is creating this on iOS? The design may be applicable on both platforms, which is fine.

2) [:jjiang] should build three things:

1. A shortcut with an icon representing the clipboarded url.

2. If the thing that you copied is a set of words instead of a link, we’d like to provide a shortcut called “Search for [keyword]”.

3. A 'Paste & Go' context menu?

Comment 11

[Bram Pitoyo [:bram]]

Hi Susheel,

Although the images are titled “Focus for Android”, the design is supposed to be multi-platform. Paste & Go (the context menu) and the “Copied” area are design patterns that I’ve found on both iOS and Android. So it pays for us to keep some consistency going. Although in this case she’s working just on iOS!

At any rate, sorry for the confusion.

To answer your second question: yes, there are three elements to this bug: an icon representing the clipboard, a different wording if your clipboard contains keyword (instead of a URL), and a context menu item.

Comment 12

[Jessica Jiang [:jjiang]]

Attachment: current specs

Hey everyone, these are the current specs @bram and I are working on for this bug. Please feel free to add input!

Comment 13

[Bram Pitoyo [:bram]]

Attachment: current specs

Thanks, Jessica, for posting the current specs!

I’ve updated it very slightly to provide iOS (platform-appropriate) screens, as well as detail exactly what we show on that area when different items are copied on the clipboard.

Comment 14

[Jessica Jiang [:jjiang]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/focus/pull/66#pullrequestreview-44987163

Comment 15

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8877238 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/focus/pull/66#pullrequestreview-44987163

Almost there. See comments in the PR. Thanks!

Comment 16

[:sdaswani]

Comment on attachment 8877238 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/focus/pull/66#pullrequestreview-44987163

Please close this once the PR is merged.