1310270 - Mozreview server reports wrong (gzipped) file size for 'Download Diff'

Status: RESOLVED INVALID

(MozReview Graveyard :: General, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The Mozreview server reports the gzipped file size in the response header, not the actual one.

Steps to reproduce:
0. Set Firefox in the Options/Preferences to ask where files should be saved.
1. Open https://reviewboard.mozilla.org/r/83600/diff/1#index_header
2. Click on "Download Diff".
Actual result:
Download dialog claims file is 112 KB big. If you check the response headers from the developer tools' Network tab, you will find Content-Length: "114219".
3. Check the file size on disk. It's 574309 bytes.
Gzipping that file returns approximately the size from step 2 (didn't try to get an exact match with the options).

Comment 1

[:glob ✱]

the content-length header should be the amount of data transferred, not the size after decompression:

https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.4
> The transfer-length of a message is the length of the message-body
> as it appears in the message; that is, after any transfer-codings
> have been applied.

so what review board is returning is correct.