1310321 - Remove unnecessary uses of Expose*ToActiveJS from CodeGen.py

Status: REOPENED

(Core :: DOM: Core & HTML, defect, P3)

Comment 1

[Andrew McCreight [:mccr8]]

Although, the uses here seem to be reading out of a Rooted<> and not a Heap<> so maybe there's no read barrier?

Comment 2

[Andrew McCreight [:mccr8]]

Ok, I guess we can't really do this. I suppose in the future ideally we'd never store a gray object into a Rooted<>.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Hmm.  Which uses are you looking at?

In order:

1)  The one in the isAny() case in getWrapTemplateForType() is there because
    for any types we just had callees hand out Value and not worry about
    unmarking.  But now that Heap unmarks, I think this can become an assert.
2)  The isObject() case in the same method, same thing, both branches.
3)  The isObject() case in CGEventGetter, is returning a property stored
    in a HeapObject, so is already getting barriered.
4)  The isAny() case in CGEventGetter is returning from a HeapValue.
4)

Comment 4

[Andrew McCreight [:mccr8]]

Oh, sorry, I was only looking at the invariants local to the method. It makes sense that all getters read from a Heap<> etc.

Comment 5

[Andrew Overholt [:overholt]]

I'm assuming P3 here due to the lack of recent activity but feel free to correct me :)