1310345 - Change the aName argument of FindItemWithName to nsAString& from char16_t*

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Change FindChildWithName and related methods to take nsAString& instead of char16_t*

MozReview-Commit-ID: 4aQwYX9ObcN

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Can't r? you so a ni? will have to do.

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: Change FindChildWithName and related methods to take nsAString& instead of char16_t*

Updated

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8801812 [details] [diff] [review]
Change FindChildWithName and related methods to take nsAString& instead of char16_t*

>@@ -5350,17 +5346,17 @@ nsDocShell::LoadErrorPage(nsIURI* aURI, const char16_t* aURL,
>+                      nullptr, nullptr, INTERNAL_LOAD_FLAGS_INHERIT_PRINCIPAL, NullString(),

Why not just EmptyString()?  Should be fine, imo: nothing inside InternalLoad checks whether the string is null, right?

Same in the other callers in this file where you pass NullString().

r=me.  Thank you for doing this!

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Attachment: Change FindChildWithName and related methods to take nsAString& instead of char16_t*

Updated to use EmptyString() instead of NullString()

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a31079dae25
Change FindChildWithName and related methods to take nsAString& instead of char16_t*, r=bz

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2a31079dae25