Closed Bug 1310345 Opened 4 years ago Closed 4 years ago

Change the aName argument of FindItemWithName to nsAString& from char16_t*

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: nika, Assigned: nika)

References

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Can't r? you so a ni? will have to do.
Flags: needinfo?(bzbarsky)
Attachment #8801372 - Attachment is obsolete: true
Comment on attachment 8801812 [details] [diff] [review]
Change FindChildWithName and related methods to take nsAString& instead of char16_t*

>@@ -5350,17 +5346,17 @@ nsDocShell::LoadErrorPage(nsIURI* aURI, const char16_t* aURL,
>+                      nullptr, nullptr, INTERNAL_LOAD_FLAGS_INHERIT_PRINCIPAL, NullString(),

Why not just EmptyString()?  Should be fine, imo: nothing inside InternalLoad checks whether the string is null, right?

Same in the other callers in this file where you pass NullString().

r=me.  Thank you for doing this!
Flags: needinfo?(bzbarsky)
Attachment #8801812 - Flags: review+
Updated to use EmptyString() instead of NullString()
Attachment #8801812 - Attachment is obsolete: true
Pushed by michael@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a31079dae25
Change FindChildWithName and related methods to take nsAString& instead of char16_t*, r=bz
https://hg.mozilla.org/mozilla-central/rev/2a31079dae25
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.