Change the aName argument of FindItemWithName to nsAString& from char16_t*

RESOLVED FIXED in Firefox 52

Status

()

Core
DOM
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: mystor, Assigned: mystor)

Tracking

unspecified
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
Created attachment 8801372 [details] [diff] [review]
Change FindChildWithName and related methods to take nsAString& instead of char16_t*

MozReview-Commit-ID: 4aQwYX9ObcN
Can't r? you so a ni? will have to do.
Flags: needinfo?(bzbarsky)
Created attachment 8801812 [details] [diff] [review]
Change FindChildWithName and related methods to take nsAString& instead of char16_t*

Updated
(Assignee)

Updated

10 months ago
Attachment #8801372 - Attachment is obsolete: true
Comment on attachment 8801812 [details] [diff] [review]
Change FindChildWithName and related methods to take nsAString& instead of char16_t*

>@@ -5350,17 +5346,17 @@ nsDocShell::LoadErrorPage(nsIURI* aURI, const char16_t* aURL,
>+                      nullptr, nullptr, INTERNAL_LOAD_FLAGS_INHERIT_PRINCIPAL, NullString(),

Why not just EmptyString()?  Should be fine, imo: nothing inside InternalLoad checks whether the string is null, right?

Same in the other callers in this file where you pass NullString().

r=me.  Thank you for doing this!
Flags: needinfo?(bzbarsky)
Attachment #8801812 - Flags: review+
Created attachment 8801889 [details] [diff] [review]
Change FindChildWithName and related methods to take nsAString& instead of char16_t*

Updated to use EmptyString() instead of NullString()
(Assignee)

Updated

10 months ago
Attachment #8801812 - Attachment is obsolete: true

Comment 6

10 months ago
Pushed by michael@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a31079dae25
Change FindChildWithName and related methods to take nsAString& instead of char16_t*, r=bz

Comment 7

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2a31079dae25
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52

Updated

10 months ago
Blocks: 1313858
You need to log in before you can comment on or make changes to this bug.