Closed
Bug 1310345
Opened 8 years ago
Closed 8 years ago
Change the aName argument of FindItemWithName to nsAString& from char16_t*
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: nika, Assigned: nika)
References
Details
Attachments
(1 file, 2 obsolete files)
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
MozReview-Commit-ID: 4aQwYX9ObcN
Assignee | ||
Comment 3•8 years ago
|
||
Updated
Assignee | ||
Updated•8 years ago
|
Attachment #8801372 -
Attachment is obsolete: true
Comment 4•8 years ago
|
||
Comment on attachment 8801812 [details] [diff] [review] Change FindChildWithName and related methods to take nsAString& instead of char16_t* >@@ -5350,17 +5346,17 @@ nsDocShell::LoadErrorPage(nsIURI* aURI, const char16_t* aURL, >+ nullptr, nullptr, INTERNAL_LOAD_FLAGS_INHERIT_PRINCIPAL, NullString(), Why not just EmptyString()? Should be fine, imo: nothing inside InternalLoad checks whether the string is null, right? Same in the other callers in this file where you pass NullString(). r=me. Thank you for doing this!
Flags: needinfo?(bzbarsky)
Attachment #8801812 -
Flags: review+
Assignee | ||
Comment 5•8 years ago
|
||
Updated to use EmptyString() instead of NullString()
Assignee | ||
Updated•8 years ago
|
Attachment #8801812 -
Attachment is obsolete: true
Pushed by michael@thelayzells.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2a31079dae25 Change FindChildWithName and related methods to take nsAString& instead of char16_t*, r=bz
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2a31079dae25
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•