Open Bug 1310448 Opened 8 years ago Updated 2 years ago

Intermittent toolkit/components/narrate/test/browser_narrate.js | Uncaught exception - TypeError: voiceOption is null

Categories

(Toolkit :: Reader Mode, defect, P2)

Product:
Toolkit
Component:
Reader Mode
Type:
defect

Tracking

()

Status:
REOPENED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- fixed

People

(Reporter: aryx, Assigned: eeejay)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1310448 - Wait for narrate button to appear before starting tests.
58 bytes, text/x-review-board-request
Gijs
: review+
Details 
Saw this twice today.

https://treeherder.mozilla.org/logviewer.html#?job_id=37732235&repo=mozilla-inbound

[task 2016-10-15T14:07:47.300133Z] 14:07:47     INFO -  547 INFO TEST-START | toolkit/components/narrate/test/browser_narrate.js
[task 2016-10-15T14:07:49.082882Z] 14:07:49     INFO -  *************************
[task 2016-10-15T14:07:49.085682Z] 14:07:49     INFO -  A coding exception was thrown and uncaught in a Task.
[task 2016-10-15T14:07:49.087990Z] 14:07:49     INFO -  Full message: TypeError: voiceOption is null
[task 2016-10-15T14:07:49.091512Z] 14:07:49     INFO -  Full stack: this.NarrateTestUtils.selectVoice@chrome://mochitests/content/browser/toolkit/components/narrate/test/NarrateTestUtils.jsm:73:5
[task 2016-10-15T14:07:49.093203Z] 14:07:49     INFO -  @chrome://mochikit/content/tests/BrowserTestUtils/content-task.js line 52 > eval:25:8
[task 2016-10-15T14:07:49.094996Z] 14:07:49     INFO -  TaskImpl_run@resource://gre/modules/Task.jsm:322:42
[task 2016-10-15T14:07:49.097615Z] 14:07:49     INFO -  Async*TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:399:7
[task 2016-10-15T14:07:49.099201Z] 14:07:49     INFO -  TaskImpl_run@resource://gre/modules/Task.jsm:330:15
[task 2016-10-15T14:07:49.101094Z] 14:07:49     INFO -  TaskImpl@resource://gre/modules/Task.jsm:280:3
[task 2016-10-15T14:07:49.103649Z] 14:07:49     INFO -  createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:254:14
[task 2016-10-15T14:07:49.110146Z] 14:07:49     INFO -  Task_spawn@resource://gre/modules/Task.jsm:168:12
[task 2016-10-15T14:07:49.113385Z] 14:07:49     INFO -  @chrome://mochikit/content/tests/BrowserTestUtils/content-task.js:54:5
[task 2016-10-15T14:07:49.115253Z] 14:07:49     INFO -  *************************
[task 2016-10-15T14:07:49.121942Z] 14:07:49     INFO -  TEST-INFO | started process screentopng
[task 2016-10-15T14:07:51.083060Z] 14:07:51     INFO -  TEST-INFO | screentopng: exit 0
[task 2016-10-15T14:07:51.085899Z] 14:07:51     INFO -  548 INFO *** Start BrowserChrome Test Results ***
[task 2016-10-15T14:07:51.087802Z] 14:07:51     INFO -  549 INFO checking window state
[task 2016-10-15T14:07:51.089517Z] 14:07:51     INFO -  550 INFO Entering test bound testNarrate
[task 2016-10-15T14:07:51.092703Z] 14:07:51     INFO -  551 INFO Console message: [JavaScript Error: "Error requesting favicon URL for about:reader content: favicon not found for uri" {file: "resource://app/modules/ReaderParent.jsm" line: 66}]
[task 2016-10-15T14:07:51.094344Z] 14:07:51     INFO -  onRejection@resource://app/modules/ReaderParent.jsm:66:13
[task 2016-10-15T14:07:51.095914Z] 14:07:51     INFO -  Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:940:21
[task 2016-10-15T14:07:51.098254Z] 14:07:51     INFO -  this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:816:7
[task 2016-10-15T14:07:51.103575Z] 14:07:51     INFO -  Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747:11
[task 2016-10-15T14:07:51.107465Z] 14:07:51     INFO -  this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:779:7
[task 2016-10-15T14:07:51.109490Z] 14:07:51     INFO -  this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:714:7
[task 2016-10-15T14:07:51.111421Z] 14:07:51     INFO -  this.PlacesUtils.promiseFaviconLinkUrl/<@resource://gre/modules/PlacesUtils.jsm:1662:9
[task 2016-10-15T14:07:51.114548Z] 14:07:51     INFO -  552 INFO TEST-PASS | toolkit/components/narrate/test/browser_narrate.js | popup is initially hidden - true == true -
[task 2016-10-15T14:07:51.117122Z] 14:07:51     INFO -  553 INFO TEST-PASS | toolkit/components/narrate/test/browser_narrate.js | popup toggled - true == true -
[task 2016-10-15T14:07:51.119165Z] 14:07:51     INFO -  554 INFO TEST-PASS | toolkit/components/narrate/test/browser_narrate.js | voice options are initially hidden - true == true -
[task 2016-10-15T14:07:51.123063Z] 14:07:51     INFO -  555 INFO TEST-PASS | toolkit/components/narrate/test/browser_narrate.js | voice options pop up - true == true -
[task 2016-10-15T14:07:51.126539Z] 14:07:51     INFO -  556 INFO TEST-UNEXPECTED-FAIL | toolkit/components/narrate/test/browser_narrate.js | Uncaught exception - TypeError: voiceOption is null
[task 2016-10-15T14:07:51.130026Z] 14:07:51     INFO -  557 INFO Leaving test bound testNarrate
Regression from bug 1294765?
Flags: needinfo?(eitan)
The way that narrate is initialized has changed. Tweaking the tests to wait for the toggle button to be unhidden should hopefully do the trick.
Flags: needinfo?(eitan)
Comment on attachment 8801854 [details]
Bug 1310448 - Wait for narrate button to appear before starting tests.

https://reviewboard.mozilla.org/r/86474/#review85240
Attachment #8801854 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c03226a59d48
Wait for narrate button to appear before starting tests. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/c03226a59d48
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Assignee: nobody → eitan
status-firefox50: --- → unaffected
status-firefox51: --- → unaffected
Still failing.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Priority: -- → P2
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: