1310491 - Canceling "Complete action using" still downloads the whole file and leaves it inaccessible

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Download Manager, defect, P1)

Description

[Christian Ascheberg]

Tested on a Nexus 4 running stock Android 5.1.1.

Steps to reproduce:
1. [Example] Open Mozilla Nightly website and click link to download apk
2. Firefox will show a dialog "Complete action using"
3. Tap Android back button to cancel

Result:
Firefox will download the whole file in the background without any visual indication.
This leads to increased data usage and wasted storage space. You can see the used storage space in "Settings - Storage - Downloads". It is not easily possible to delete the .part file, because it is not listed in the Android Downloads app, and it is not deleted when clearing app cache.

Expected:
Maybe the download should not even start at that step. But the download should at least stop and the .part file should be deleted.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

We should not use speculative downloading when on mobile data. It should continue to work when on WiFi.

Comment 2

[Julien Cristau [:jcristau]]

Mass wontfix for bugs affecting firefox 52.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

From bug 1426156 comment 7:

> Speculatively starting the download in the background is the intended behaviour,

I would think the user needs to consent to dowloading before we begin a download on the basis of privacy, potential exploits, and unexpected data usage. To me, clicking a link does not constitute consent to download something to the device.

[triage] Moving P1 to re-evaluate but I'm not convinced this is critical. Susheel, what do you think?

Comment 5

[Jan Henning [:JanH]]

(In reply to Michael Comella (:mcomella) [please needinfo for a response] from comment #4)
> From bug 1426156 comment 7:
> 
> > Speculatively starting the download in the background is the intended behaviour,
> 
> I would think the user needs to consent to dowloading before we begin a
> download on the basis of privacy, potential exploits

I don't see why we should be in a different situation than desktop Firefox here...

> and unexpected data usage.

... though I agree on that one, at least when we're on a metered connection.

Comment 6

[Jan Henning [:JanH]]

I'd suggest leaving any further discussion regarding speculative downloads on metered connections or otherwise to bug 1384811.

As for the immediate issue at hand, I think I've found where we made a mistake.

Comment 7

[Jan Henning [:JanH]]

Attachment: Bug 1310491 - Part 1 - Always properly clear speculative downloads when forwarding a download.

If we have to forward a download that we cannot handle ourselves to the Android
download manager, then the speculative download started by Firefox needs to be
aborted no matter whether forwarding succeeded or not.

Review commit: https://reviewboard.mozilla.org/r/216082/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216082/

Comment 8

[Jan Henning [:JanH]]

Attachment: Bug 1310491 - Part 2 - Abort speculative download if user backs out of our App Chooser dialogue.

Review commit: https://reviewboard.mozilla.org/r/216084/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216084/

Comment 9

[:sdaswani]

Mike, given we have a proposed fix, let's keep it P1 and assume it gets closed soon. We can reevaluate if it doesn't.

Comment 10

[Eugen Sawin [:esawin]]

Comment on attachment 8946015 [details]
Bug 1310491 - Part 1 - Always properly clear speculative downloads when forwarding a download.

https://reviewboard.mozilla.org/r/216082/#review222032

Comment 11

[Eugen Sawin [:esawin]]

Comment on attachment 8946016 [details]
Bug 1310491 - Part 2 - Abort speculative download if user backs out of our App Chooser dialogue.

https://reviewboard.mozilla.org/r/216084/#review222036

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fecef9e5df9a
Part 1 - Always properly clear speculative downloads when forwarding a download. r=esawin
https://hg.mozilla.org/integration/autoland/rev/e479bda148a0
Part 2 - Abort speculative download if user backs out of our App Chooser dialogue. r=esawin

Comment 13

[Jan Henning [:JanH]]

Comment on attachment 8946016 [details]
Bug 1310491 - Part 2 - Abort speculative download if user backs out of our App Chooser dialogue.

Approval Request Comment
[Feature/Bug causing the regression]: Downloads on Android
[User impact if declined]: If the user cancels a download by exiting our app chooser dialogue without choosing anything, the download continues invisibly in background.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Verified locally.
[Needs manual test from QE? If yes, steps to reproduce]: 1. Start a download that triggers our app chooser dialogue, e.g. an APK download from ftp.mozilla.org.
2. Press "back" to exit the dialogue without choosing anything.
3. No temporary ".part" file should be left behind in the Downloads directory.
[List of other uplifts needed for the feature/fix]: Part 1, although it's an optional improvement and not strictly necessary to fix the main issue.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: Just adding the missing call to actually cancel the speculative background download if the user chooses nothing. We already cancel the download in the same way when the user *does* choose to complete the download with an app other than Firefox.
[String changes made/needed]: none

Comment 14

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/fecef9e5df9a
https://hg.mozilla.org/mozilla-central/rev/e479bda148a0

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

Sorina, can you verify the fix on nightly before we uplift to beta? Thanks!

Comment 16

[Sorina Florean [:sflorean]]

I was able to reproduce the issue on 59.0b5 and release builds with Nexus 5 (Android 6.0.1) and Google Pixel (Android 8.0) following the steps from description and comment 13. Tested on latest Nightly build (60.0a1 from 01/31) with the affected devices, following the same steps, and the apk.part file was not displayed in storage.
So verified as fixed on Nightly 60.

Comment 17

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8946016 [details]
Bug 1310491 - Part 2 - Abort speculative download if user backs out of our App Chooser dialogue.

Verified in Nightly, let's uplift for beta 6.

Comment 18

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8946015 [details]
Bug 1310491 - Part 1 - Always properly clear speculative downloads when forwarding a download.

It looks like this should also be uplifted to beta along with part 2. Jan, is that correct?

Comment 19

[Liz Henry (:lizzard) (relman/hg->git project)]

Ah, I see where you mentioned Part 1 now.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/22861495469e
https://hg.mozilla.org/releases/mozilla-beta/rev/fa6ec1c75d75

Comment 21

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8946016 [details]
Bug 1310491 - Part 2 - Abort speculative download if user backs out of our App Chooser dialogue.

The user impact here is pretty severe, fix was verified on nightly60, safe enough to include as a ride-along in Fennec 58.0.2.

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/e41e39373525

Comment 23

[Bogdan Surd, QA [:bsurd, NI]]

Device:
 - Samsung Galaxy Tab S3 (Android 7.0);

 Verified this using the steps provided in Comment 13 in both Beta (59.0b7) and Release (58.0.2), the issue is fixed nothing has been downloaded without the user actually confirming the download action. 
 Marking as verified.

Comment 24

[za1175014]

I have tested this on Firefox for android on version 58.0.2 and Firefox Beta 59.0 on android this issue of speculative download still exists and has not been resolved, downloads still start without even asking in background and continue even after exiting the "app Chooser" dialogue.  I have tested this on Xiaomi Mi A1 Android One device running on android Oreo. Please solve this bug it is consuming a lot of mobile data in the background just today i have lost 1GB of mobile internet data.

Comment 26

[Jan Henning [:JanH]]

(In reply to za1175014 from comment #24)
> downloads still start without even asking in background
That is a known limitation of the way downloads currently work, see bug 1384811 and bug 
438905.

> continue even after exiting the "app Chooser" dialogue.
I'm afraid I can't reproduce that.

Comment 27

[Brindusa Tot, Desktop QA]

This bug was verified on Firefox 58, 59, 60. Remove the Qe-verify+ flag.