Closed Bug 1310612 Opened 3 years ago Closed 3 years ago

Request to rename directory external_tests because it is tedious to type

Categories

(NSS :: Test, defect)

3.28
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mt, Assigned: mt)

References

(Blocks 1 open bug)

Details

And now it has a prefix collision with exports.gyp.  Let's rename it to simply gtests.
external_tests/nss_bogo_shim isn't exactly a gtest.  But it's the only not-gtest there, and maybe it could go into cmd/.
kai, you originally asked for the name "external_tests", can you explain why?  Would you object to a name change?
Flags: needinfo?(kaie)
My thinking was, if you're adding google code to NSS, it should be immediately obvious for everyone that it depends on alien code with different rules/copyright.
Flags: needinfo?(kaie)
From external_tests/google_test/gtest/LICENSE:
  Copyright 2008, Google Inc.
  All rights reserved.
(In reply to Kai Engert (:kaie) from comment #4)
> From external_tests/google_test/gtest/LICENSE:
>   Copyright 2008, Google Inc.
>   All rights reserved.

which seems to be contrary to the COPYING file we have in the main directory
Gerv, could you please give us advice related to having a copy of the Google gtest framework as part of the NSS tree?

https://github.com/google/googletest/tree/master/googletest

https://hg.mozilla.org/projects/nss/file/tip/external_tests/google_test/gtest

Is it a good idea to have a indicative parent directory name for that code inside the NSS tree?

Or is that even insufficient, and we should rather modify the toplevel COPYING file used by NSS?
Flags: needinfo?(gerv)
Summary: external_tests is tedious to type → Request to rename directory external_tests because it is tedious to type
Kai, my non-legal understanding is that the BSD license is compatible with the NSS license (MPL).  Given that the LICENSE file for google_test is included, that seems to meet their license requirements.

The question then is whether the name of the directory has any bearing on this.
(In reply to Kai Engert (:kaie) from comment #6)
> Is it a good idea to have a indicative parent directory name for that code
> inside the NSS tree?

Yes. The best thing with imported libraries is to put them in their own directory, with their COPYING / LICENSE file. However, there are no restrictions on what that directory may be called.

Gerv
Flags: needinfo?(gerv)
With Gerv's comment, I'm OK with a name change.

Do you want to rename it to gtests?
Done:
https://hg.mozilla.org/projects/nss/rev/c70fffcd487e4a91f1d3775e8ffb1505f54a9fe6
Assignee: nobody → martin.thomson
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.28
Blocks: 1313814
You need to log in before you can comment on or make changes to this bug.