1310664 - Add a field to datastore in order to identify crash ping type

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Metrics: Pipeline, defect)

Description

[David Durst [:ddurst]]

Once we have more types of crash pings than just browser (bug 1293656), we will need to be able to separate those post-submission.

Comment 1

[Thomas Huelbert]

whats your timeline on needs David?

Comment 2

[Benjamin Smedberg]

Which datastore are we talking about?

We definitely need to update crash_aggregates, because that drives the crash rate dashboards. I don't know what other datasets exist right now.

Comment 3

[David Durst [:ddurst]]

Sorry, bit of a shorthand here, (but I'm glad this came up because I missed a link on the dependency tree).

For this bug, I'm only talking about adding this to the pings (aka storage on S3). Benjamin's concern is addressed in bug 1310680 (and via bug 1310673).

thuelbert -- we're looking to land this this week or next. If I understand it correctly, we are able to do this ourselves without impact on anything else.

Let me know if this is incorrect. Our intention is basically to start landing crash pings with stacks (today) followed by content crash pings (with and without stacks). But we want to make sure we don't disrupt anything in the process.

Comment 4

[Mauro Doglio [:mdoglio]]

:ddurst you can do that yourselves unless it's a new ping type. And this is not the case from what I understand. The only bit that requires coordination is bug 1310673.

Comment 5

[Mauro Doglio [:mdoglio]]

I *think* this bug is a dupe of bug 1293656. :ddurst can you confirm that?

Comment 6

[David Durst [:ddurst]]

I wouldn't say it's a dupe, but they're close. 1293656 addresses including stack traces in the content crash ping. This addresses needing to differentiate between types of crash pings (of which content crash pings are the first kind since browser crash pings).

Comment 7

[Gabriele Svelto [:gsvelto] (PTO)]

I think that with bug 1310673 being fixed we can close this too, right?

Comment 8

[Mauro Doglio [:mdoglio]]

This still depends on bug 1293656