1310673 - Update CrashAggregatesView.scala in telemetry-batch-view to accommodate (new) content crash ping type field

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Metrics: Pipeline, defect, P1)

Description

[David Durst [:ddurst]]

Bug 1310664 and bug 1293656 result in crash pings having a new field identifying the crash ping type. Crash Aggregates will need to reflect/include this new field.

Comment 1

[Chris H-C :chutten]

This should just be a matter of excluding crash pings with non-browser process types. Once the field name and location is finalized in the crash ping schema, it'll probably just be a matter of augmenting somewhere near line 53 [1] to check the process type.

Ideally, eventually, we'll be able to switch crash_aggregates' content crash columns over to being sourced via content-process-type "crash" pings so we can get that data faster (right now we have to wait for "main" pings to trickle in). There's not too much of a rush on that just yet, I don't think. This work can probably wait until we want to add support for non-content child processes.

[1]: https://github.com/mozilla/telemetry-batch-view/blob/master/src/main/scala/com/mozilla/telemetry/views/CrashAggregateView.scala#L53

Comment 2

[Mauro Doglio [:mdoglio]]

I'm happy to take this bug, I just need to know the name/location of the new field and what values to expect.

Comment 3

[GitHub Autolander Bot]

Attachment: [telemetry-batch-view] mozilla:bug-1310673-add-process-type > mozilla:master

Comment 4

[Mauro Doglio [:mdoglio]]

:rvitillo gave an r+ on github. This is now on master