Closed Bug 1310732 Opened 5 years ago Closed 5 years ago

Stop using ScopedNSSTypes Scoped.h types in c-c

Categories

(MailNews Core :: Security: S/MIME, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 52.0

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

Details

Attachments

(1 file)

Scoped.h is deprecated, and the unique_ptr based UniqueX types should be used instead.
I can compile TB locally with this patch, but I haven't tested things still work.
Attachment #8802050 - Flags: review?(rkent)
Are we running the risk of bustage here? Will Scoped.h be removed by M-C? If so, where and when? I remember that in bug 1308548 I had to do the rubber-stamping since we were already busted before Kent got to the review.
(In reply to Jorg K (GMT+2) from comment #2)
> Are we running the risk of bustage here?
If the review request is promptly looked at, no.
I am slowly getting rid of the ScopedX stuff in m-c via various bugs, but it'll be a while (at least a week) until I reach the point where it will result in c-c bustage. I will comment here before I reach that point.

> Will Scoped.h be removed by M-C? If so, where and when?
Maybe at some unspecified point in time - see Bug 1037100 and Bug 1037103.
Regardless, it shouldn't matter. AFAICT, the only uses of Scoped.h in c-c are being removed here.

> I remember that in bug 1308548 I had to do the rubber-stamping since we were already busted before Kent got to the review.
I filed this early to avoid that, but I probably won't wait long if I have patches that depend on the one that causes the bustage, sorry.
Comment on attachment 8802050 [details] [diff] [review]
bug1310732_stop-using-scoped.h-c-c_v1.patch

Review of attachment 8802050 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this. I confirmed that all of of the changes make sense, and did a smoke test of smime sending and receiving. All seems good.
Attachment #8802050 - Flags: review?(rkent) → review+
I'll land it soon, preferably together with some other patch.
Keywords: checkin-needed
Actually I've already landed it with another patch.

http://hg.mozilla.org/comm-central/rev/ec0c3abd5590
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 52.0
You need to log in before you can comment on or make changes to this bug.