Closed Bug 1310749 Opened 3 years ago Closed 3 years ago

grep in repack-stage in lightning-packager.mk doesn't seem to work

Categories

(Calendar :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: iann_bugzilla, Assigned: aleth)

References

Details

Attachments

(1 file, 1 obsolete file)

As I was looking through some repack issues I spotted that the following did not seem to be working on my build box (Fedora 24):
grep -v 'locale \w\+ en-US'
and from testing it doesn't seem to understand \w as that only covers [A-Za-z0-9_] whereas for some callers they contain -
Putting aleth on CC who may have some time to fix this up, it seems it should be a quick fix.
Component: Lightning Only → Build Config
(In reply to Ian Neal from comment #0)
> As I was looking through some repack issues I spotted that the following did
> not seem to be working on my build box (Fedora 24):
> grep -v 'locale \w\+ en-US'
> and from testing it doesn't seem to understand \w as that only covers
> [A-Za-z0-9_] whereas for some callers they contain -

Which callers are those? Afaik that's supposed to match either 'locale calendar en-US' or 'locale lightning en-US', and neither lightning or calendar contains a hyphen.
The gdata provider is a caller and uses gdata-provider
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Attachment #8802028 - Flags: review?(philipp)
Attachment #8802026 - Attachment is obsolete: true
Attachment #8802026 - Flags: review?(philipp)
https://hg.mozilla.org/comm-central/rev/eaabbc4918cf9762ac5de3c3b3078aa278fffa09
Bug 1310749 - Fix grep in lightning-packager.mk for gdata-provider. r=philipp
Attachment #8802028 - Attachment is obsolete: true
Attachment #8802028 - Flags: review?(philipp)
Attachment #8802026 - Attachment is obsolete: false
Attachment #8802026 - Flags: review+
r+ via IRC
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 5.4
Attachment #8802026 - Flags: approval-calendar-aurora?(philipp)
https://hg.mozilla.org/releases/comm-aurora/rev/bd21c84fff3b7a6efb62a047efbcbece547c4419
Bug 1310749 - Fix grep in lightning-packager.mk for gdata-provider. r=philipp a=aleth
Attachment #8802026 - Flags: approval-calendar-aurora?(philipp) → approval-calendar-aurora+
Depends on: 1311115
Target Milestone: 5.4 → 5.3
You need to log in before you can comment on or make changes to this bug.