131078 - Compiler warning fixes

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P1)

Description

[Wan-Teh Chang]

I fixed some of the compiler warnings from compiling
NSS 3.4 on Red Hat Linux 7.2.  A patch is coming up.

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch

The compiler warnings I fixed include:
1. implicit declaration of functions;
2. mismatch of fprintf format specifiers and arguments;
3. trigraph ??/ converted to \ ;
4. missing 'const' ;
5. __CERT_NewTempCertificate is not declared in cert.h,
but CERT_NewTempCertificate is.

Please review my patch.  Thanks.

Comment 2

[Ian McGreer]

Comment on attachment 74270 [details] [diff] [review]
Proposed patch

looks good to me (wow, cleanup of the tools ;)

Comment 3

[Wan-Teh Chang]

Fix checked in.

Comment 4

[Wan-Teh Chang]

If you know a better way to fix the trigraph problem
(??/ converted to \), please let me know.

The other idea I have is to change "??/" to "?\?/".
I find that less readable than "??" "/".

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

I don't understand the change to certutil.c
It appears that the old and new lines are identical.  
Was the change in that file simply an addition or deletion of whitespace?
What warning did that fix?

As for trigraphs, is there an option to disable them, so the linux
compiler won't alter string constants?

Comment 6

[Wan-Teh Chang]

Comment on attachment 74270 [details] [diff] [review]
Proposed patch

Nelson,

>Index: mozilla/security/nss/cmd/certutil/certutil.c
>===================================================================
>RCS file: /cvsroot/mozilla/security/nss/cmd/certutil/certutil.c,v
>retrieving revision 1.50
>diff -u -r1.50 certutil.c
>--- mozilla/security/nss/cmd/certutil/certutil.c	27 Feb 2002 22:12:06 -0000	1.50
>+++ mozilla/security/nss/cmd/certutil/certutil.c	15 Mar 2002 03:46:30 -0000
>@@ -1119,7 +1119,7 @@
>     FPS "\t%s -R -s subj -o cert-request-file [-d certdir] [-P dbprefix] [-p phone] [-a]\n"
> 	"\t\t [-k key-type] [-h token-name] [-f pwfile] [-g key-size]\n",
> 	progName);
>-    FPS "\t%s -V -n cert-name -u usage [-b time] [-e] \n",
>+    FPS "\t%s -V -n cert-name -u usage [-b time] [-e] \n"
> 	"\t\t[-X] [-d certdir] [-P dbprefix]\n",
> 	progName);
>     FPS "\t%s -S -n cert-name -s subj [-c issuer-name | -x]  -t trustargs\n"

In this change, I removed the comma (,) so that the two string
literals are concatenated by the compiler, which is the intention
of the code.  (That's what the neighboring FPS statements do.)

The compiler warned that there is only one format specifier
(%s) but two arguments (the second string literal and 'progName').

>@@ -1301,7 +1301,7 @@
> 	"   -d certdir");
>     FPS "%-20s Cert & Key database prefix\n",
> 	"   -P dbprefix");
>-    FPS "%-20s Token to reset (default is internal)\n"
>+    FPS "%-20s Token to reset (default is internal)\n",
> 	"   -h token-name");
>     FPS "\n");

In this change, I added a comma (,) so that the two string
literals are NOT concatenated by the compiler.	Again, if
you look at the neighboring FPS statements, you'll see that
that's the intention of the code.

The compiler warned that there is one format specifier (%-20s)
but no argument (because the two string literals are concatenated).

Comment 7

[Nelson Bolyard (seldom reads bugmail)]

Thanks,  I looked several times but didn't see those commas in the diffs.