1310794 - implement aria-details and aria-errormessage

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

https://www.w3.org/TR/wai-aria-1.1/#aria-errormessage
https://www.w3.org/TR/wai-aria-1.1/#aria-details

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 2

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 8801847 [details] [diff] [review]
patch

Review of attachment 8801847 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. Please give me a heads up if you have other ARIA impl plans -- especially while we are laser focused on multiprocess.

::: accessible/tests/mochitest/relations/test_general.html
@@ +400,5 @@
>      <input />
>    </fieldset>
> +
> +  <input id="has_details" aria-details="details"><section id="details"></section>
> +  <input id="has_error" aria-errormessage="error"><section id="error"></section>

Curious why you chose inputs...

Comment 4

[alexander :surkov (:asurkov)]

(In reply to David Bolter [:davidb] from comment #3)

> r=me. Please give me a heads up if you have other ARIA impl plans --

Nothing else so far, that's the only thing we sorted out with Rich, Jamie and others on IA2 mail list.

> especially while we are laser focused on multiprocess.

This shouldn't cross multiprocess plans by any means, these attributes are fairly new and neither of them used on the web yet. I would say it's a low risk.

> > +  <input id="has_details" aria-details="details"><section id="details"></section>
> > +  <input id="has_error" aria-errormessage="error"><section id="error"></section>
> 
> Curious why you chose inputs...

just something accessible, what may have details or error message provided

Comment 5

[alexander :surkov (:asurkov)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=698a6da10dd3

Comment 6

[alexander :surkov (:asurkov)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=359128c06345

Comment 7

[alexander :surkov (:asurkov)]

Windows doesn't like RelationType::ERROR constant:

 6:56.30 Unified_cpp_accessible_xpcom0.cpp
 6:56.30 accessible_xpcom.lib.desc
 6:56.30 COMPtrTypes.cpp
 6:56.30 c:\mozilla\inbound\obj-i686-pc-mingw32\dist\include\mozilla/a11y/RelationType.h(130): error C2059: syntax error: 'constant'
 6:56.30 c:\mozilla\inbound\obj-i686-pc-mingw32\dist\include\mozilla/a11y/RelationType.h(130): error C3805: 'constant': unexpected token, expected either '}' or a ','

So suggesting to rename it to ERRORMSG (ERRORMSG_FOR) which is closer to ARIA, but further from IA2.

Comment 8

[alexander :surkov (:asurkov)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8de847e619dd

Comment 9

[alexander :surkov (:asurkov)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c3a589e8af7

Comment 10

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/22dd21caab66dd9c0504c6b984a096639f916e5a
Bug 1310794 - implement aria-details and aria-errormessage, r=davidb

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/22dd21caab66