Closed Bug 1310794 Opened 3 years ago Closed 3 years ago

implement aria-details and aria-errormessage

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: surkov, Assigned: surkov)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
Attachment #8801846 - Flags: review?(dbolter)
Attached patch patchSplinter Review
Assignee: nobody → surkov.alexander
Attachment #8801846 - Attachment is obsolete: true
Attachment #8801846 - Flags: review?(dbolter)
Attachment #8801847 - Flags: review?(dbolter)
Comment on attachment 8801847 [details] [diff] [review]
patch

Review of attachment 8801847 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. Please give me a heads up if you have other ARIA impl plans -- especially while we are laser focused on multiprocess.

::: accessible/tests/mochitest/relations/test_general.html
@@ +400,5 @@
>      <input />
>    </fieldset>
> +
> +  <input id="has_details" aria-details="details"><section id="details"></section>
> +  <input id="has_error" aria-errormessage="error"><section id="error"></section>

Curious why you chose inputs...
Attachment #8801847 - Flags: review?(dbolter) → review+
(In reply to David Bolter [:davidb] from comment #3)

> r=me. Please give me a heads up if you have other ARIA impl plans --

Nothing else so far, that's the only thing we sorted out with Rich, Jamie and others on IA2 mail list.

> especially while we are laser focused on multiprocess.

This shouldn't cross multiprocess plans by any means, these attributes are fairly new and neither of them used on the web yet. I would say it's a low risk.

> > +  <input id="has_details" aria-details="details"><section id="details"></section>
> > +  <input id="has_error" aria-errormessage="error"><section id="error"></section>
> 
> Curious why you chose inputs...

just something accessible, what may have details or error message provided
Windows doesn't like RelationType::ERROR constant:

 6:56.30 Unified_cpp_accessible_xpcom0.cpp
 6:56.30 accessible_xpcom.lib.desc
 6:56.30 COMPtrTypes.cpp
 6:56.30 c:\mozilla\inbound\obj-i686-pc-mingw32\dist\include\mozilla/a11y/RelationType.h(130): error C2059: syntax error: 'constant'
 6:56.30 c:\mozilla\inbound\obj-i686-pc-mingw32\dist\include\mozilla/a11y/RelationType.h(130): error C3805: 'constant': unexpected token, expected either '}' or a ','

So suggesting to rename it to ERRORMSG (ERRORMSG_FOR) which is closer to ARIA, but further from IA2.
https://hg.mozilla.org/mozilla-central/rev/22dd21caab66
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.