1310862 - nightly 20161017 compile fails with disabled options fatal error: mozilla/dom/GamepadMessageUtils.h: No such file or directory

Status: RESOLVED DUPLICATE of bug 1310904

(Core :: Graphics, defect)

Description

[u532768]

Attachment: local .mozconfig with many disabled options, presumably one of them is causing the problem

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20161016095902

Steps to reproduce:

upgraded local hg repository to latest nightly.  mach compiled


Actual results:

1:02.45 In file included from /mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/ipc/ipdl/_ipdlheaders/mozilla/gfx/PVRManager.h:20:0,
 1:02.45                  from /mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/ipc/ipdl/_ipdlheaders/mozilla/gfx/PVRManagerChild.h:9,
 1:02.45                  from /mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/dist/include/VRManagerChild.h:11,
 1:02.45                  from /mnt/to_archive/accum/src/mozilla-central/widget/nsBaseWidget.cpp:76:
 1:02.45 /mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/ipc/ipdl/_ipdlheaders/mozilla/dom/GamepadEventTypes.h:20:45: fatal error: mozilla/dom/GamepadMessageUtils.h: No such file or directory
 1:02.45  #include "mozilla/dom/GamepadMessageUtils.h"
 1:02.45                                              ^
 1:02.45 compilation terminated.
 1:02.49 
 1:02.49 In the directory  /mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/widget
 1:02.49 The following command failed to execute properly:
 1:02.51 /usr/bin/ccache /usr/lib64/ccache/g++ -std=gnu++11 -o nsBaseWidget.o -c -I/mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/dist/stl_wrappers -I/mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/dis
t/system_wrappers -include /mnt/to_archive/accum/src/mozilla-central/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DMOZ_CROSS_PROCESS_IME -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/mnt/to_ar
chive/accum/src/mozilla-central/widget -I/mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/widget -I/mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/ipc/ipdl/_ipdlheaders -I/mnt/to_archive/accum/src/mozill
a-central/ipc/chromium/src -I/mnt/to_archive/accum/src/mozilla-central/ipc/glue -I/mnt/to_archive/accum/src/mozilla-central/dom/base -I/mnt/to_archive/accum/src/mozilla-central/dom/ipc -I/mnt/to_archive/accum/src/mozilla-central/layout/ba
se -I/mnt/to_archive/accum/src/mozilla-central/layout/forms -I/mnt/to_archive/accum/src/mozilla-central/layout/generic -I/mnt/to_archive/accum/src/mozilla-central/layout/xul -I/mnt/to_archive/accum/src/mozilla-central/view -I/mnt/to_archi
ve/accum/src/mozilla-central/widget -I/mnt/to_archive/accum/src/mozilla-central/widget/gtk -I/mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/dist/include -I/mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gn
u/dist/include/nspr -I/mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/mozilla-config.h -MD -MP -MF .deps/
nsBaseWidget.o.pp -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wc++14-compat -Wno-error=maybe-uninitiali
zed -Wno-error=deprecated-declarations -Wno-error=array-bounds -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe -g -Wall -fno-schedule-insns2 -fno-lifetime-dse -fno-delete-null-pointer-checks -
O3 -fomit-frame-pointer -I/mnt/to_archive/accum/src/mozilla-central/widget/gtk/compat-gtk3 -pthread -I/usr/include/gtk-3.0/unix-print -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 
-I/usr/lib64/dbus-1.0/include -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pi
xman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/freetype2 -I/usr/include/libdrm -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -Wn
o-error=shadow /mnt/to_archive/accum/src/mozilla-central/widget/nsBaseWidget.cpp
 1:06.22 libdom_mathml.a.desc
 1:06.89 gmake[5]: *** [/mnt/to_archive/accum/src/mozilla-central/config/rules.mk:939: nsBaseWidget.o] Error 1
 1:06.89 gmake[5]: *** Waiting for unfinished jobs....


Expected results:

PASS
PASS

Comment 1

[u532768]

Here's a result of a bisect:

The first bad revision is:
changeset:   318208:16414aeacf43
user:        Daosheng Mu <[e-mail]>
date:        Tue Oct 04 16:30:04 2016 +0800
summary:     Bug 1299928 - Part 3: Construct IPC channel between Gamepad and VRManager; r=kip

changeset:   318208:16414aeacf43
user:        Daosheng Mu <[e-mail]>
date:        Tue Oct 04 16:30:04 2016 +0800
files:       dom/gamepad/GamepadManager.cpp dom/gamepad/GamepadManager.h gfx/vr/gfxVR.h gfx/vr/ipc/PVRManager.ipdl gfx/vr/ipc/VRManagerChild.cpp gfx/vr/ipc/VRManagerChild.h gfx/vr/ipc/VRMessageUtils.h gfx/vr/moz.build
description:
Bug 1299928 - Part 3: Construct IPC channel between Gamepad and VRManager; r=kip

MozReview-Commit-ID: 9hpxlLlIdh7

Comment 2

[Daosheng Mu[:daoshengmu]]

I have submitted a patch at Bug 1310904. That should fix it.

Comment 3

[Daosheng Mu[:daoshengmu]]

Stan, please help me check if you use --disable-gamepad config to build Nightly?

Comment 4

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8801924 [details]
local .mozconfig with many disabled options, presumably one of them is causing the problem

>. $topsrcdir/browser/config/mozconfig
>
>ac_add_options --enable-application=browser
>ac_add_options --prefix="/usr/local"
>ac_add_options --libdir="/usr/local/lib64"
>ac_add_options --with-pthreads
>ac_add_options --enable-default-toolkit=cairo-gtk3
>ac_add_options --enable-chrome-format=omni
>ac_add_options --enable-bundled-fonts
>ac_add_options --with-x
>ac_add_options --with-ccache
>ac_add_options --enable-extensions=default
>ac_add_options --disable-gamepad               <<< Well. This is the root cause.
>ac_add_options --disable-webspeech        # Disable support for HTML Speech API
>ac_add_options --disable-accessibility    # Disable accessibility support
>ac_add_options --disable-webrtc           # Disable support for WebRTC
>ac_add_options --disable-websms-backend
>ac_add_options --disable-android-omx
>ac_add_options --disable-tests
>ac_add_options --disable-necko-wifi
>ac_add_options --disable-updater
>ac_add_options --disable-parental-controls
>ac_add_options --disable-debug
>ac_add_options --disable-safe-browsing
>ac_add_options --disable-url-classifier
>ac_add_options --disable-gio
>ac_add_options --with-intl-api
>ac_add_options --enable-optimize=" -Wall -fno-schedule-insns2 -fno-lifetime-dse -fno-delete-null-pointer-checks -O3"

Comment 5

[Daosheng Mu[:daoshengmu]]

Stan, could you help me try the attachment 8802116 [details] [diff] [review] patch at Bug 1310904. Thanks.

Comment 6

[Daosheng Mu[:daoshengmu]]

I saw some errors in Ubuntu. I am going to investigate.

Comment 7

[u532768]

re:comment 3

Yes, nightly 20161020 compiles without problems if I remove the disable gamepad.

Comment 8

[u532768]

Re: Comment 5

I'm willing to try the patch.  Can you tell me how to apply it in such a way that my hg repository remains in sync with the main repository?

Thanks.

Comment 9

[u532768]

I tried to patch the hg repository with your patch.  This is up to date as of 20161021.  It gave the following errors.

$ patch -p1 --dry-run <0001-Bug-1310904-Solve-compiling-errors-in-non-MOZ_GAMEPA.patch
checking file dom/gamepad/Gamepad.h
checking file dom/gamepad/GamepadManager.cpp
Hunk #1 succeeded at 581 (offset 5 lines).
checking file dom/gamepad/GamepadManager.h
checking file dom/gamepad/GamepadPlatformService.cpp
checking file dom/gamepad/GamepadServiceTest.cpp
checking file dom/gamepad/ipc/GamepadEventTypes.ipdlh
checking file dom/gamepad/ipc/GamepadMessageUtils.h
checking file dom/gamepad/ipc/GamepadServiceType.h
checking file dom/gamepad/ipc/GamepadTestChannelParent.cpp
checking file dom/gamepad/moz.build
checking file gfx/vr/gfxVR.cpp
checking file gfx/vr/gfxVR.h
Hunk #3 FAILED at 247.
1 out of 3 hunks FAILED
checking file gfx/vr/gfxVROpenVR.cpp
Hunk #2 FAILED at 573.
1 out of 2 hunks FAILED
checking file gfx/vr/ipc/VRManagerChild.cpp

Comment 10

[Jan Beich]

Let's keep feedback in one place. Since bug 1311460 landed there's nothing BSD-specific left in bug 1310904.