Closed Bug 1310882 Opened 3 years ago Closed 3 years ago

Urlbar zoom button in dark devedition has poor hover support

Categories

(Firefox :: Theme, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 52
Tracking Status
firefox51 --- verified
firefox52 --- verified

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(1 file)

On Default theme, the hover effect looks good.
On Developer Edition theme:
- On Windows, the hover effect is not visible on dark mode
- On Mac, the hover effect is barely visible on dark mode
- On Ubuntu, the zoom level value loses visibility on hover state on dark mode
This patch only fixes the issue for Windows right now. I'll be back to my Mac by Wednesday and can test/write a similar patch for OSX then if need be. Same for Ubuntu.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Comment on attachment 8801946 [details]
Bug 1310882 - Urlbar zoom button in dark devedition has poor hover support.

https://reviewboard.mozilla.org/r/86534/#review85652

::: browser/themes/windows/devedition.css:111
(Diff revision 1)
>     (brighttext only covers the unselected tabs) */
>  .tab-close-button[selected=true] {
>    list-style-image: url("chrome://global/skin/icons/close-inverted.png");
>  }
>  
> +[devtoolstheme="dark"] #urlbar-zoom-button:hover {

Nit: use :root to be consistent and so (ideally) layout can optimize these kinds of selectors?
Attachment #8801946 - Flags: review?(gijskruitbosch+bugs) → review+
Oh, thanks for catching that! I had :root at one point in the patch, not sure how it got removed.
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/260defd06226
Urlbar zoom button in dark devedition has poor hover support. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/260defd06226
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Comment on attachment 8801946 [details]
Bug 1310882 - Urlbar zoom button in dark devedition has poor hover support.

Approval Request Comment
[Feature/regressing bug #]: regression of new feature shipping in firefox 51
[User impact if declined]: poor devedition theme support with zoom indicator
[Describe test coverage new/current, TreeHerder]: manual testing, baked on central for > 1 week
[Risks and why]: low risk, only CSS change
[String/UUID change made/needed]: none
Attachment #8801946 - Flags: approval-mozilla-aurora?
Comment on attachment 8801946 [details]
Bug 1310882 - Urlbar zoom button in dark devedition has poor hover support.

Polish UI in devedition. Take it in 51 aurora.
Attachment #8801946 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: qe-verify+
Before verifying the fix I reproduced the issue on Windows 10, Ubuntu 16.04 and Mac 10.11 with an Aurora/Nightly build from 2016-10-16.

I verified the fix on Aurora 51.0a2 (Build ID 20161107004002) with Developer Edition theme and the hover looks good. I tested on:
*Windows 10
*Ubuntu 16.04
*Mac 10.11

I also verified the fix on Nightly 52.0a1 (Build ID 20161107030203) using the same OS-es and I can confirm the fix. For testing in Nightly I installed an add-on in order to have the Developer Edition theme enabled and the URL bar to be dark (https://addons.mozilla.org/ro/firefox/addon/devedition-theme-enabler/).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.