Create UA override for m.canadiantire.ca

RESOLVED FIXED

Status

RESOLVED FIXED
2 years ago
4 months ago

People

(Reporter: adamopenweb, Assigned: adamopenweb)

Tracking

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

2 years ago
We should create a UA override for m.canadiantire.ca in fennec as mentioned here: https://webcompat.com/issues/2315#issuecomment-254447551

Spoofing the user agent makes the site work properly for us. Tested using this UA:

Mozilla/5.0 (Linux; Android 6.0.1; Nexus 6 Build/MMB29X) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.89 Mobile Safari/537.36
(Assignee)

Comment 1

a year ago
Issue still exists can't use in Fennec. Canadiantire.ca is ranked 83 in Canada on Alexa.
(Assignee)

Comment 2

a year ago
Created attachment 8868736 [details] [diff] [review]
Add m.canadiantire.ca override to ua-update.json.in

Using the same user agent string as the Direct TV entry.
Assignee: nobody → astevenson
Attachment #8868736 - Flags: review?(miket)
(Assignee)

Comment 3

a year ago
Created attachment 8868750 [details] [diff] [review]
Adding m.canadiantire.ca override
Attachment #8868750 - Flags: review?(miket)
Comment on attachment 8868750 [details] [diff] [review]
Adding m.canadiantire.ca override

Review of attachment 8868750 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

(Note: We need to add r=miketaylr at the end of the commit message before checking it in.)
Attachment #8868750 - Flags: review?(miket) → review+
Adam, can you tweak the commit message then add the "checkin-needed" keyword?
Flags: needinfo?(astevenson)
> add the "checkin-needed" keyword

(To be clear, that keyword gets added to this bug.)
(Assignee)

Comment 7

a year ago
Created attachment 8873548 [details] [diff] [review]
Adding m.canadiantire.ca override
Attachment #8868750 - Attachment is obsolete: true
Flags: needinfo?(astevenson)
Attachment #8873548 - Flags: review+
(Assignee)

Updated

a year ago
Keywords: checkin-needed

Comment 8

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ecad8cb9f20c
Add UA override for m.canadiantire.ca. r=miketaylr
Keywords: checkin-needed

Comment 9

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ecad8cb9f20c
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
(Assignee)

Comment 10

a year ago
Mike, I tested this but we're still getting blocked in fennec. Can you take a look at it please?
Flags: needinfo?(miket)
Thanks Adam. I filed 1376569 to see what's up with the CDN not syncing.
Let's re-open until the fix is deployed to users.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This has been fixed for a while. Forgot to update.
Status: REOPENED → RESOLVED
Last Resolved: a year ago9 months ago
Resolution: --- → FIXED
(Assignee)

Updated

4 months ago
See Also: → bug 1457514
You need to log in before you can comment on or make changes to this bug.