Closed Bug 1310956 Opened 3 years ago Closed 3 years ago

moz.build generator from GYP should use that target_arch is arm64 instead of aarch64

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox52 fixed)

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file)

Chromium (V8 and WebRTC etc) code uses that target_arch is arm64 when using aarch64 target.  But our generator sets that target_arch is aarch64, not arm64.

So we should use arm64 instead of aarch64.
Comment on attachment 8803230 [details]
Bug 1310956 - Use arm64 for target_arch into GYP.

https://reviewboard.mozilla.org/r/87540/#review87250

::: media/webrtc/trunk/build/common.gypi:1030
(Diff revision 1)
>                    }, {
>                      'android_app_abi%': 'armeabi-v7a',
>                    }],
>                  ],
>                }],
> -              ['target_arch=="aarch64"', {
> +              ['target_arch=="arm64"', {

This should be upstreamed, too.
Comment on attachment 8803230 [details]
Bug 1310956 - Use arm64 for target_arch into GYP.

https://reviewboard.mozilla.org/r/87540/#review87252
Attachment #8803230 - Flags: review?(mh+mozilla) → review+
(In reply to Mike Hommey [:glandium] from comment #2)
> This should be upstreamed, too.

This line is for mozilla only.  Also, chromium (chromium_common.gypi) has same change.
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/38b8e489b7f2
Use arm64 for target_arch into GYP. r=glandium
https://hg.mozilla.org/mozilla-central/rev/38b8e489b7f2
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.