1310956 - moz.build generator from GYP should use that target_arch is arm64 instead of aarch64

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Makoto Kato [:m_kato]]

Chromium (V8 and WebRTC etc) code uses that target_arch is arm64 when using aarch64 target.  But our generator sets that target_arch is aarch64, not arm64.

So we should use arm64 instead of aarch64.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1310956 - Use arm64 for target_arch into GYP.

Google's projects using GYP use arm64 for target_arch instead of aarch64.  So we should use it for moz.build generator.

Review commit: https://reviewboard.mozilla.org/r/87540/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/87540/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8803230 [details]
Bug 1310956 - Use arm64 for target_arch into GYP.

https://reviewboard.mozilla.org/r/87540/#review87250

::: media/webrtc/trunk/build/common.gypi:1030
(Diff revision 1)
>                    }, {
>                      'android_app_abi%': 'armeabi-v7a',
>                    }],
>                  ],
>                }],
> -              ['target_arch=="aarch64"', {
> +              ['target_arch=="arm64"', {

This should be upstreamed, too.

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8803230 [details]
Bug 1310956 - Use arm64 for target_arch into GYP.

https://reviewboard.mozilla.org/r/87540/#review87252

Comment 4

[Makoto Kato [:m_kato]]

(In reply to Mike Hommey [:glandium] from comment #2)
> This should be upstreamed, too.

This line is for mozilla only.  Also, chromium (chromium_common.gypi) has same change.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/38b8e489b7f2
Use arm64 for target_arch into GYP. r=glandium

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/38b8e489b7f2