moz.build generator from GYP should use that target_arch is arm64 instead of aarch64

RESOLVED FIXED in Firefox 52

Status

Firefox Build System
General
RESOLVED FIXED
2 years ago
3 months ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
mozilla52

Firefox Tracking Flags

(firefox52 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Chromium (V8 and WebRTC etc) code uses that target_arch is arm64 when using aarch64 target.  But our generator sets that target_arch is aarch64, not arm64.

So we should use arm64 instead of aarch64.
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8803230 [details]
Bug 1310956 - Use arm64 for target_arch into GYP.

https://reviewboard.mozilla.org/r/87540/#review87250

::: media/webrtc/trunk/build/common.gypi:1030
(Diff revision 1)
>                    }, {
>                      'android_app_abi%': 'armeabi-v7a',
>                    }],
>                  ],
>                }],
> -              ['target_arch=="aarch64"', {
> +              ['target_arch=="arm64"', {

This should be upstreamed, too.

Comment 3

2 years ago
mozreview-review
Comment on attachment 8803230 [details]
Bug 1310956 - Use arm64 for target_arch into GYP.

https://reviewboard.mozilla.org/r/87540/#review87252
Attachment #8803230 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 4

2 years ago
(In reply to Mike Hommey [:glandium] from comment #2)
> This should be upstreamed, too.

This line is for mozilla only.  Also, chromium (chromium_common.gypi) has same change.

Comment 5

2 years ago
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/38b8e489b7f2
Use arm64 for target_arch into GYP. r=glandium

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/38b8e489b7f2
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52

Updated

3 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.