Stop using nsIDialogParamBlock in deletecert.(js|xul)

RESOLVED FIXED in Firefox 52

Status

()

Core
Security: PSM
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

Tracking

unspecified
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

(Whiteboard: [psm-assigned])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
An nsIDialogParamBlock is unnecessary for how deletecert.(js|xul) is currently used.
Moreover, nsIDialogParamBlock is arguably a poor API, so moving away from it is also advantageous.
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8802546 [details]
Bug 1310961 - Stop using nsIDialogParamBlock in deletecert.(js|xul).

https://reviewboard.mozilla.org/r/86932/#review88878
Attachment #8802546 - Flags: review?(mgoodwin) → review+
(Assignee)

Comment 3

2 years ago
Thanks!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f39fdc04b559451a987fec1a11a8357197ea79e
The failures look unrelated.
Keywords: checkin-needed

Comment 4

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c3384531cc0
Stop using nsIDialogParamBlock in deletecert.(js|xul). r=mgoodwin
Keywords: checkin-needed

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8c3384531cc0
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.