Closed Bug 1310968 Opened 8 years ago Closed 4 years ago

Sync fails on history: dbConnection is not defined

Categories

(Firefox :: Sync, defect, P3)

Product:
Firefox
Component:
Sync
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1120552

People

(Reporter: wiwwo+github, Unassigned)

References

Details

User Agent: Opera/9.64 (Macintosh; PPC Mac OS X; U; en) Presto/2.1.1

Steps to reproduce:

(Given sync properly configured to sync at least browsing history)
0 - On device A, be sure you are not in a Private Browsing window
1 - On device A, visit www.firefox.com
2 - On device A, force synchronization, and wait one minute
3 - On device B, force synchronization, and wait one minute
4 - On device B, check whether www.firefox.com is in browsing history
5 - On device B, delete history entry for www.firefox.com
6 - On device B, force synchronization, and wait one minute
7 - On device A, force synchronization, and wait one minute

This happens on ANY kind of A/B device(s), being Android tablet, windows/linux PC, Android mobile.


Actual results:

History item www.firefox.com deleted on device B disappeared;
history item www.firefox.com not deleted in device A


Expected results:

History item www.firefox.com should be deleted on ANY device
Component: Untriaged → Sync
Flags: needinfo?(markh)
I can't reproduce this - however, a current limitation of Sync is that changes made within the first 10 or so seconds after startup are missed - is that likely to be the case here?
Flags: needinfo?(markh) → needinfo?(wiwwo+github)
Uhm.. nope... :-)
I delete history using 
https://addons.mozilla.org/es/firefox/addon/history-deleter/
on FF 45.4.0 ESR - Justo to say the wirdoest way to delete history.
Yes, it is outdated, but it deletes history items, NO magic.

In my other Andriod FF version, not a single item deleted on FF-ESR got deleted
Can you reproduce using the builtin History sidebar? It's possible that extension talks directly to the DB, so Sync doesn't get notified of the change.
Nope.
Went into browsing history on desktop browser
deleted aaaaaall "google.com/search" and all other search engine urls
forced syncing into desktop browser
waited one minute
forced syncing into desktop browser
waited two minutes
opened FF on android
Forced sync
aaaaaall "google.com/search" and all other search engine urls still there
Can you please follow the instructions at https://wiki.mozilla.org/CloudServices/Sync/File_a_desktop_bug to enable "success" logging for Sync, then reproduce your problem and upload the success logs here - that should confirm if desktop is or is not syncing the deletion. If possible, it would also be ideal if you could try and reproduce on 2 desktop Firefox versions - it may be that Firefox on Android is not syncing this deletion correctly (although I can't find a bug on file for that)
1478103777269	Sync.Engine.Forms	WARN	Failed to reconcile incoming record 9MTdg5SORsyg73v4
1478103777269	Sync.Engine.Forms	WARN	Encountered exception: ReferenceError: dbConnection is not defined (resource://gre/modules/FormHistory.jsm:407:5) JS Stack trace: dbCreateAsyncStatement@FormHistory.jsm:407:5 < makeSearchStatement@FormHistory.jsm:272:10 < formHistorySearch@FormHistory.jsm:783:16 < FormWrapper._searchSpinningly@forms.js:51:5 < FormWrapper.hasGUID@forms.js:86:12 < FormStore.prototype.itemExists@forms.js:164:12 < SyncEngine.prototype._reconcile@engines.js:1267:27 < SyncEngine.prototype._processIncoming/newitems.recordHandler@engines.js:1087:23 < Collection.prototype.recordHandler/this._onProgress@record.js:628:9 < Channel_onDataAvail@resource.js:561:7 < waitForSyncCallback@async.js:102:7 < Res__request@resource.js:408:14 < Res_get@resource.js:432:12 < SyncEngine.prototype._processIncoming@engines.js:1173:18 < SyncEngine.prototype._sync@engines.js:1545:7 < WrappedNotify@util.js:148:21 < Engine.prototype.sync@engines.js:669:5 < _syncEngine@enginesync.js:214:7 < sync@enginesync.js:164:15 < onNotify@service.js:1309:7 < WrappedNotify@util.js:148:21 < WrappedLock@util.js:103:16 < _lockedSync@service.js:1299:12 < sync/<@service.js:1291:14 < WrappedCatch@util.js:77:16 < sync@service.js:1279:5


With different record IDs, this WARN (???) is being logged maaaaaany times:

$ grep "dbConnection is not defined" * | wc -l
442
$ ls err*txt | wc -l
115
Strange thing is: new items are synced, just deleted ones are not being removed from history! :-S
Component: Sync → Firefox Sync: Backend
Product: Firefox → Cloud Services
It's difficult to guess exactly why it is failing for you, but bug 1120552 tracks the underlying problem. This is basically a dupe of that bug, but I'll keep this open for now as it is specific to Sync.
Status: UNCONFIRMED → NEW
Depends on: 1120552
Ever confirmed: true
Flags: needinfo?(wiwwo+github)
Summary: Sync does not synchronize deleted history items → Sync fails on history: dbConnection is not defined
Priority: -- → P3
This might still be a problem. Sync and Places won't behave well if the database is corrupt, or the connection otherwise fails.
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox

I don't think there's value in having this and bug 1120552 both open.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.