131116 - Add check for self-builds to eliminate 'The Mozilla build you are using is older than three weeks' message.

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[[e-mail] (gone - use [e-mail] instead)]

Summary: Add check for self-builds to eliminate 'The Mozilla build you are using
is older than three weeks' message.

Self-admittingly, my JS style sucks, but I really don't see a need for a
switch/case clause here.

My fix just detects if the user has 10 zeros (strings, not ints) and then bails
out of the rest of the check with a return statement.

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Fix

Comment 2

[[e-mail] (gone - use [e-mail] instead)]

Comment on attachment 74304 [details] [diff] [review]
Fix

Yeah, I suck.  Check for equality, not commence on assignment!

Comment 3

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Fix, with equality check, not assignment!

Comment 4

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 74305 [details] [diff] [review]
Fix, with equality check, not assignment!

r=glazman (I am unable to see the checkbox in the attachment management window)

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Same patch, cvs diff -u

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 74306 [details] [diff] [review]
Same patch, cvs diff -u

please insert some spaces around the ==...

do that and sr=[e-mail]

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

Fixed

http://www.mozilla.org/webtools/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=index.html&root=/cvsroot&subdir=mozilla-org/html/start&command=DIFF_FRAMESET&rev1=1.11&rev2=1.12

Comment 8

[timeless]

for reference you can't use return outside of a function.