Closed Bug 1311248 Opened 8 years ago Closed 7 years ago

Unhide eslint and flake8 on Gecko 51 and below if they ever actually run on the revision they claim to have run on

Categories

(Tree Management Graveyard :: Visibility Requests, defect)

Product:
Tree Management Graveyard
Component:
Visibility Requests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: philor, Unassigned)

References

Details

(Whiteboard: [leave-open])

Attachments

(3 obsolete files) 

Bug 1292071 means both that they run on a working directory with a random assortment of files in it, and that they don't actually show bustage until much later, generally when the bustage gets merged around. Bit of a party foul, that.
Comment on attachment 8803453 [details]
Bug 1311248 - Fix 'line too long' in mozinfo.py to unhide flake8,

https://reviewboard.mozilla.org/r/87722/#review86688
Attachment #8803453 - Flags: review?(ted) → review+
Comment on attachment 8803474 [details]
Bug 1311248 - Fix eslint 'linebreak-style' errors in devtools inspector tests to unhide eslint,

https://reviewboard.mozilla.org/r/87730/#review86694

Thanks!
Attachment #8803474 - Flags: review?(jryans) → review+
Comment on attachment 8803473 [details]
Bug 1311248 - Fix eslint 'spaced-comment' errors in ext-windows.js to unhide eslint,

https://reviewboard.mozilla.org/r/87728/#review86696

This one seems fine to me as well!
Attachment #8803473 - Flags: review+
Attachment #8803473 - Flags: review?(erahm)
These 3 changes are in the autoland queue waiting for trees to re-open. The f8 task should be good to unhide immediately (it is currently only busted on autoland, but should be fixed as soon as trees re-open and this lands).

The ES task can be unhidden on autoland at least as it should be fixed by this on that branch. There is some fx-team only bustage that I missed but which Mossop is fixing in bug 1312055.

Philor, would you mind unhiding at least flake8?
Depends on: 1312055
Flags: needinfo?(philringnalda)
Whiteboard: [leave-open]
Heh, I can't load treeherder because the internet is broken, but it will be fixed by something which hasn't yet landed, that gets the prize for most premature unhide request this week :)
Flags: needinfo?(philringnalda)
That's fair..

In an ideal world lint bustage would be fixed by follow-up fixes 90% of the time, and only result in a backout in the worst case scenario (i.e author/reviewer can't be reached and no one else volunteers to fix it). Prematurely un-hiding would be no different than waiting for a follow-up fix. Unfortunately the sheriffing model doesn't have a provision for "allowed to be busted for short periods of time".
(500 words elided)

Yeah, maybe sometime after someone makes tier-2 even vaguely remotely slightly workable, they could then work on making that workable.
I've just pushed bug 1312055 to autoland on behalf of Mossop, so I think ES should start greening up there now.

Though I think we still need to land the flake8 patch for that part of lint?
Attachment #8803453 - Attachment is obsolete: true
The commit that caused the f8 bustage got backed out for other reasons so it's green as well. So currently f8 is green everywhere and ES is green on autoland.
Attachment #8803473 - Attachment is obsolete: true
Attachment #8803473 - Flags: review?(erahm)
Attachment #8803474 - Attachment is obsolete: true
Attachment #8803474 - Flags: review+
Wes, could you unhide this tasks ? thanks
Flags: needinfo?(wkocher)
That would, apparently, be a "no."

Unhidden on trunk trees, I presume it will remain unfixed on 51 and below.
Flags: needinfo?(wkocher)
Thanks. I'm not sure where the taskcluster refactor that regressed them is yet (ie this might not even be a problem on aurora yet), but either way it's probably fine to leave them hidden on non-trunk trees until the fix gets merged around. An argument could be made these jobs don't really need to run there anyway.
Summary: Unhide eslint and flake8 when they actually run on the revision they claim to have run on → Unhide eslint and flake8 on Gecko 51 and below if they ever actually run on the revision they claim to have run on
Carsten has just enabled this on mozilla-release. So we're all enabled now in the right places.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: