Closed Bug 1311267 Opened 4 years ago Closed 4 years ago

DecodingFirstFrameState should override HandleDormant()

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(1 file)

DecodingFirstFrameState might already have a queued seek job (if seek can't be handled immediately) before entering the dormant state. We should keep the queued job instead of storing mCurrentPosition into mQueuedSeek.mTarget in StateObject::HandleDormant() [1].

[1] http://searchfox.org/mozilla-central/rev/d96317a351af8aa78ab9847e7feed964bbaac7d7/dom/media/MediaDecoderStateMachine.cpp#204
Assignee: nobody → jwwang
Blocks: 1295892
Priority: -- → P3
Attachment #8802412 - Flags: review?(kikuo)
Comment on attachment 8802412 [details]
Bug 1311267 - DecodingFirstFrameState should override HandleDormant().

https://reviewboard.mozilla.org/r/86808/#review86156
Attachment #8802412 - Flags: review?(kikuo) → review+
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0f5bb48b0bc3
DecodingFirstFrameState should override HandleDormant(). r=kikuo
https://hg.mozilla.org/mozilla-central/rev/0f5bb48b0bc3
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.