1311267 - DecodingFirstFrameState should override HandleDormant()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

DecodingFirstFrameState might already have a queued seek job (if seek can't be handled immediately) before entering the dormant state. We should keep the queued job instead of storing mCurrentPosition into mQueuedSeek.mTarget in StateObject::HandleDormant() [1].

[1] http://searchfox.org/mozilla-central/rev/d96317a351af8aa78ab9847e7feed964bbaac7d7/dom/media/MediaDecoderStateMachine.cpp#204

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1311267 - DecodingFirstFrameState should override HandleDormant().

Review commit: https://reviewboard.mozilla.org/r/86808/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/86808/

Comment 2

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8802412 [details]
Bug 1311267 - DecodingFirstFrameState should override HandleDormant().

https://reviewboard.mozilla.org/r/86808/#review86156

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f5bb48b0bc3
DecodingFirstFrameState should override HandleDormant(). r=kikuo

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0f5bb48b0bc3