1311269 - [Pointer Events] Should only use `sendMouseEvent()` and `sendTouchEvent()` in PE testcases

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Ben Hsu [:HoPang]]

We should only use `sendMouseEvent()` and `sendTouchEvent()` in PE testcases, from which we synthesize WidgetMouseEvents and WidgetTouchEvents to test pointer events automatically. Doing this will benefit us  Now there are two testcases not following this design, test_pointerevent_attributes_mouse-manual.html and test_pointerevent_change-touch-action-onpointerdown_touch-manual.html.

Comment 1

[Ben Hsu [:HoPang]]

Attachment: Part 1: Improve PE test automation Framework

In this patch, I make both `sendMouseEvent()` and `sendTouchEvent()` more powerfull by granting the ability to decide the target position of the synthesized events.

Comment 2

[Ben Hsu [:HoPang]]

Attachment: Part 2: Update related testcases.

In the patch, I update the two testcase no using `sendMouseEvent()` and `sendTouchEvent()`. In test_pointerevent_attributes_mouse-manual.html, I use the new API. As to test_pointerevent_change-touch-action-onpointerdown_touch-manual.html, I suggest disable it since we're not using the testcase right as the comment I left in the testcase. However, it's already disabled in mochitest.ini[0].

[0] http://searchfox.org/mozilla-central/source/dom/events/test/pointerevents/mochitest.ini#17

Comment 3

[Ben Hsu [:HoPang]]

Hi Stone, do you mind giving feedback on these two patches?

Comment 4

[Ben Hsu [:HoPang]]

Comment on attachment 8802788 [details] [diff] [review]
Part 1: Improve PE test automation Framework

Hi Olli,

Do you mind reviewing these patches?
Details are described in comment 1 and comment 2, respectively.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8802788 [details] [diff] [review]
Part 1: Improve PE test automation Framework

rs+

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8802792 [details] [diff] [review]
Part 2: Update related testcases.

rs+

Comment 7

[Ben Hsu [:HoPang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=674bed93cd4c&selectedJob=29579527

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d85188ac754e
Part 1: Improve PE test automation framework. f=sshih, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/e94e8a28abd1
Part 2: Update related testcases. f=sshih, r=smaug

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d85188ac754e
https://hg.mozilla.org/mozilla-central/rev/e94e8a28abd1