1311275 - Assertion failed in mozilla::net::nsIOService::GetCachedProtocolHandler

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Gary Chen [:xeonchen]]

Attachment: backtrace

Bug 1308275 breaks the assertion |NS_IsMainThread()| in |nsIOService::GetCachedProtocolHandler|

Comment 1

[Honza Bambas (:mayhemer)]

Instead of using NS_GetFileFromURLSpec you will have to decompose that function similar way as I did that in bug 1293327 (your are cc'ed now).  

You simply need to get the file protocol directly (do_GetService) and call the GetFileFromURLSpec on it.  The goal is to not use the 'cached protocol' path, which is not thread safe.

That's all.

Comment 2

[Honza Bambas (:mayhemer)]

You can also cache the protocol yourself if that would be used too often (do_GetService is relatively slow).

Comment 3

[Mark Smith [:mcs]]

Another way to fix this would be to change nsIOService::GetCachedProtocolHandler() to be thread safe (but I assume that option was already considered).

For developers, is there a way to know which functions are thread safe? In other words, how could I have known in advance that NS_GetFileFromURLSpec() is not thread safe?

Comment 4

[Gary Chen [:xeonchen]]

Attachment: 0001-Bug-1311275-use-protocol-service-directly-instead-of.patch

Comment 5

[Gary Chen [:xeonchen]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=47700e6430e7095d2146acead65e4f4f6c4c30ed

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee15d36745a8
use protocol service directly instead of NS_GetFileFromURLSpec; r=mayhemer

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/ee15d36745a8