Closed Bug 1311290 Opened 8 years ago Closed 8 years ago

Enable the test_fetch_integrity.html and disable test_fetch_event.html

Categories

(Core :: DOM: Service Workers, defect)

Product:
Core
Component:
DOM: Service Workers
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: tt, Assigned: tt)

References

Details

Attachments

(1 file)

Patch for label the skip-if to correct test.
1.12 KB, patch
bkelly
: review+
Details | Diff | Splinter Review 
I file this bug for adding test at wrong position which change the original skipping flag to label from test_fetch_event.html to test_fetch_integrity.html. 

I misunderstood how "skip-if" work in mochitest.ini. I thought it label the below test but it's not. Sorry for that.
Hi Ben,

I added test in wrong position and it makes the skip-if flag label the wrong test. I add this patch to fix that. Could you help me to review this patch? Thanks!
Attachment #8802446 - Flags: review?(bkelly)
Attachment #8802446 - Flags: review?(bkelly) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/73c3732de185
Move the skip-if annotation to the test it was intended for. r=bkelly
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/73c3732de185
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: