1311302 - "Use of nsIFile in content process is deprecated." in filesystem.js

Status: RESOLVED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect, P2)

Description

[Sebastian Zartner [:sebo]]

+++ This bug was initially created as a clone of Bug #1287993 +++

When the DevTools are opened the following error message is logged to the Browser Console:

Use of nsIFile in content process is deprecated.  filesystem.js:40:9

Tested in Nightly 52.0a1 (2016-10-18).

Sebastian

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Seems like a GCLI bug, since that's the thing that owns filesystem.js.

Comment 2

[Joe Walker [:jwalker]]

We should be able to 'just' rip this out. I don't think we're actually using type:"file" in any command params.

My hunch is that we can delete the following files:

https://dxr.mozilla.org/mozilla-central/source/devtools/shared/gcli/source/lib/gcli/util/filesystem.js
https://dxr.mozilla.org/mozilla-central/source/devtools/shared/gcli/source/lib/gcli/util/fileparser.js
https://dxr.mozilla.org/mozilla-central/source/devtools/shared/gcli/source/lib/gcli/types/file.js
https://dxr.mozilla.org/mozilla-central/source/devtools/shared/gcli/source/lib/gcli/types/fileparser.js

We probably also need to remove line 22 of commands/index which refers to the file type:

https://dxr.mozilla.org/mozilla-central/source/devtools/shared/gcli/commands/index.js#22

Then I think we just start it up and see what breaks!

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Seems like a good first bug for the adventurous.

Comment 4

[Sebastian Zartner [:sebo]]

I could imagine that it's used by the 'inject' command to inject scripts from the local file system, or maybe by the 'folder' command to open a folder.

But that's just a gut feeling, I didn't have a look at the code at all.

Sebastian

Comment 5

[Michael Hoffmann]

Hi, I took a shot at it and tried to rip the mentioned files out.  I got failing tests for the screenshot command, and it seems like it uses the file type:
https://dxr.mozilla.org/mozilla-central/source/devtools/shared/gcli/commands/screenshot.js#45

Comment 6

[Julien Cristau [:jcristau] (back April 22)]

Mass wontfix for bugs affecting firefox 52.

Comment 7

[Luna Phipps-Costin]

I don't get this in 52.3 (linux esr) or nightly.

Comment 8

[Sebastian Zartner [:sebo]]

I still see this error with Nightly 57.0a1 (2017-08-23). It's shown when the Inspector is opened and also when opening the Developer Toolbar (Shift+F2).

Christopher, note that the error is only shown in the Browser Console (Ctrl+Shift+J)[1], *not* in the Web Console within the DevTools.

Sebastian

[1] https://developer.mozilla.org/en-US/docs/Tools/Browser_Console

Comment 9

[Luna Phipps-Costin]

Oh, Developer Toolbar means GCLI? That's not very clear terminology... Anyway, yes, I see this with GCLI. I'll take a look at this.

Comment 10

[Luna Phipps-Costin]

I removed the line Michael Brennan recommended, and now the console shows "Error: Unknown type" from `Console.jsm` /and still/ gives the original nsIFile error.

Comment 11

[Adrian Wielgosik [:adrian17]]

After bug 1429421 filesystem.js doesn't exist anymore, so this can be closed now.
(The warning for NetUtil.jsm still exists)