1311358 - Show error notification when opening RDM for container tab

Status: VERIFIED FIXED

(DevTools :: Responsive Design Mode, defect, P1)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Let's add an error notification when opening RDM on a container tab as a temporary fix until it's really supported.  This avoid breaking the tab.

See meta bug 1306975 for more details.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1311358 - Add error notification for RDM with container tabs.

Review commit: https://reviewboard.mozilla.org/r/86906/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/86906/

Comment 2

[Tim Nguyen :ntim]

Comment on attachment 8802522 [details]
Bug 1311358 - Add error notification for RDM with container tabs.

https://reviewboard.mozilla.org/r/86906/#review85928

::: dom/ipc/ContentParent.cpp:4785
(Diff revision 1)
>                                  InfallibleTArray<FrameScriptInfo>* aFrameScripts,
>                                  nsCString* aURLToLoad,
>                                  TextureFactoryIdentifier* aTextureFactoryIdentifier,
>                                  uint64_t* aLayersId)
>  {
> +  printf("RCW\n");

nit: logging leftover

Comment 3

[Tim Nguyen :ntim]

Comment on attachment 8802522 [details]
Bug 1311358 - Add error notification for RDM with container tabs.

https://reviewboard.mozilla.org/r/86906/#review86036

Works well for me!

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8802522 [details]
Bug 1311358 - Add error notification for RDM with container tabs.

https://reviewboard.mozilla.org/r/86906/#review85928

> nit: logging leftover

Wow, thanks for catching...  I'm doing too many things at once it seems (was part of a totally different bug...).

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8802522 [details]
Bug 1311358 - Add error notification for RDM with container tabs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/86906/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/455c709178a6
Add error notification for RDM with container tabs. r=ntim

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/455c709178a6

Comment 8

[Sayed [:LiquidO2]]

This bug is about showing error notification when trying to enable rdm mode in a container tab as a temporary fix of bug 1306975

I can see the error message is implemented in Latest Nightly 52.0a1 in Elementary OS 64bit

Build ID 	20161020030211
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0