putting all SQL-statements into one file

VERIFIED WONTFIX

Status

()

P5
enhancement
VERIFIED WONTFIX
17 years ago
13 years ago

People

(Reporter: kiril.sramko, Assigned: nobody)

Tracking

Details

(Reporter)

Description

17 years ago
I'm just working on bug# 106592 and I've got change a lot of the SQL-statements.
Bugzilla has 564 SendSQL()-calls, distributed thru all files. And all tables and
fields are in plain-text and not as variables writen.

And so I've got the idea to put all statements into one files as methods, whitch
could be call. This got the advanteges:
 - this file could be generate, depending on the database, the user has
 - all statemens are central and if you change the database, you jousst have to
work in one file.

So, got anybody any other ideas or critics?
-> bugzilla, but I'd just like to say that that would make everything impossible
to follow, with no real benefit that grep can't give you.
Assignee: gerv → justdave
Component: Bugzilla Helper → Bugzilla-General
Product: Webtools → Bugzilla
Version: other → unspecified
(Reporter)

Comment 2

17 years ago
But if you want to change Bugzilla that way, that it work on any DBMS you have
to make specific statements to take benefit of the different DBMS's.
So why don't put the statements in significant labelled procedures, put these in
one file and make the rest of the Bugzilla-sorce independen of the DBMS?
I'm definitely not convinced. I think the DB-independence work is all we need in
this area.

Gerv
Priority: -- → P5
Target Milestone: --- → Future
Reassigning all of my "future" targetted bugs to indicate that I'm not presently
working on them, and someone else could feel free to work on them.
Reassigning all of my "future" targetted bugs to indicate that I'm not presently
working on them, and someone else could feel free to work on them. (sorry for
the spam if you got this twice, it didn't take right the first time)
Assignee: justdave → nobody

Updated

13 years ago
QA Contact: mattyt-bugzilla → default-qa

Comment 6

13 years ago
We are moving most (all?) SQL statements into .pm modules. And our code is already compatible with at least 2 DB servers: MySQL and PostgreSQL. WONTIFX!
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → WONTFIX
Target Milestone: Future → ---
Agreed--this will not be done, because we're moving that code mostly into modules, which makes more sense.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.