Closed Bug 1311397 Opened 8 years ago Closed 8 years ago

DataChannel logging in mochitests/etc broken by switch to LazyLog

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: jesup, Assigned: jesup)

Details

(Keywords: regression)

Attachments

(1 file)

We lost some logging due to LazyLog, since MOZ_LOG/etc became case-sensitive.  

Also: should runtests.py be setting MOZ_LOG?  How is that different than automation.py.in, device.py, and utils.py?  It's rather unclear which of these to set for what purpose to someone not intimate with the python chains running tests.
Comment on attachment 8802538 [details] [diff] [review]
fix DataChannel logging for mochitests/etc

Review of attachment 8802538 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, sorry for the delay.
Attachment #8802538 - Flags: review?(erahm) → review+
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad24f084859f
fix DataChannel logging for mochitests/etc r=erahm
https://hg.mozilla.org/mozilla-central/rev/ad24f084859f
https://hg.mozilla.org/mozilla-central/rev/a49efd91c077
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Version: 49 Branch → Trunk
You need to log in before you can comment on or make changes to this bug.