Closed Bug 1311402 Opened 3 years ago Closed 3 years ago

Fix floating scrollbars in the dark theme on Windows

Categories

(DevTools :: General, defect, P1)

All
Windows
defect

Tracking

(firefox52 verified)

VERIFIED FIXED
Firefox 52
Iteration:
52.3 - Nov 14
Tracking Status
firefox52 --- verified

People

(Reporter: magicp.jp, Assigned: jryans)

References

Details

(Whiteboard: [multiviewport] [reserve-rdm])

Attachments

(3 files)

Steps to reproduce:

1. Start Nightly on Windows (e.g. Win10, Win7)
2. Go to any sites (e.g. about:home)
3. Open DevTools > Inspector with dark theme
4. Check floating scrollbars

Actual Results:

scrollbarbutton is visible

Expected Results:

scrollbarbutton is invisible in the dark theme
Blocks: 1276629
Has STR: --- → yes
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Priority: -- → P1
Iteration: --- → 52.3 - Nov 7
Flags: qe-verify?
Whiteboard: [multiviewport] [reserve-rdm]
Seems correct in my Windows 10 VM.
Flags: qe-verify? → qe-verify+
QA Contact: mihai.boldan
Comment on attachment 8802580 [details]
Bug 1311402 - Dark theme scrollbars need to also match root scrollbars.

https://reviewboard.mozilla.org/r/86940/#review86022

Works fine on my Win 10 VM as well.
Attachment #8802580 - Flags: review?(ntim.bugs) → review+
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c30204f93da8
Dark theme scrollbars need to also match root scrollbars. r=ntim
https://hg.mozilla.org/mozilla-central/rev/c30204f93da8
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Attached image verified-Bug1311402.png
verified in latest Nightly Build(20161020030211). Thanks!
According to Comment 7, I am marking this issue Verified Fixed.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.