1311414 - Activity Stream Panel: android.database.CursorIndexOutOfBoundsException: Index 24 requested, with a size of 24

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

I see some repeating crashes of the new AS panel on a Nexus 7:

>       GeckoCrashHandler  E  >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 1 ("main")
>                          E  android.database.CursorIndexOutOfBoundsException: Index 24 requested, with a size of 24
>                          E      at android.database.AbstractCursor.checkPosition(AbstractCursor.java:426)
>                          E      at android.database.AbstractWindowedCursor.checkPosition(AbstractWindowedCursor.java:136)
>                          E      at android.database.AbstractWindowedCursor.getLong(AbstractWindowedCursor.java:74)
>                          E      at android.database.CursorWrapper.getLong(CursorWrapper.java:106)
>                          E      at org.mozilla.gecko.home.activitystream.topsites.TopSitesPageAdapter.swapCursor(TopSitesPageAdapter.java:71)
>                          E      at org.mozilla.gecko.home.activitystream.topsites.TopSitesPagerAdapter.swapCursor(TopSitesPagerAdapter.java:113)
>                          E      at org.mozilla.gecko.home.activitystream.StreamItem$TopPanel.bind(StreamItem.java:59)
>                          E      at org.mozilla.gecko.home.activitystream.StreamRecyclerAdapter.onBindViewHolder(StreamRecyclerAdapter.java:85)
>                          E      at org.mozilla.gecko.home.activitystream.StreamRecyclerAdapter.onBindViewHolder(StreamRecyclerAdapter.java:22)
>                          E      at android.support.v7.widget.RecyclerView$Adapter.onBindViewHolder(Unknown Source)
> [..]

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

It appears this code has changed and we no longer call `Cursor.getLong`: https://dxr.mozilla.org/mozilla-central/rev/30ea2905130e85f9e1d8d56fa3097901eec6514b/mobile/android/base/java/org/mozilla/gecko/activitystream/homepanel/topsites/TopSitesPageAdapter.java#58

I can't find this crash in crash-stats.

Sebastian, do you think this crash is still occurring?

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Michael Comella (:mcomella) from comment #1)
> Sebastian, do you think this crash is still occurring?

The AS top sites code has changed over time. It's very likely that this doesn't happen anymore.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Could be fixed by this patch that introduced an additional cursor size check here:
https://hg.mozilla.org/mozilla-central/rev/7d5fa98f80d1

Comment 4

[Chenxia Liu [:liuche]]

Agreed, I'll WFM right now, can reopen if there are more reports, but I haven't seen any more crashes through 54.