Remove devtools/client/promisedebugger

RESOLVED FIXED in Firefox 52

Status

defect
P1
normal
RESOLVED FIXED
3 years ago
a year ago

People

(Reporter: jryans, Assigned: jryans)

Tracking

49 Branch
Firefox 52

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
The old debugger has a (disabled by default) promise debugger feature.  (It is sufficiently disabled that even after using old debugger and enabling "devtools.debugger.promise", it was still hidden AFAICT.)

Since this would need to be rewritten for the new debugger anyway, we may want to just remove it at the stage.  On IRC, :gl suggested removing may be reasonable.
Assignee

Comment 1

3 years ago
:gl, :jlongster, thoughts?
Flags: needinfo?(jlong)
Flags: needinfo?(gl)
Let's go ahead with this since there aren't any current resources allocated to working on the promise debugger. We can easily re-add the boilerplate code, but I suspect we will also do a bit of a rewrite to utilize react/redux.
Flags: needinfo?(gl)
Sounds fine to me. I'm not really familiar with it or how much code it is, but if would help to remove it let's do it.
Flags: needinfo?(jlong)
Comment hidden (mozreview-request)
Assignee

Updated

3 years ago
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Priority: -- → P1

Comment 6

3 years ago
mozreview-review
Comment on attachment 8804896 [details]
Bug 1311506 - Remove promise debugger.

https://reviewboard.mozilla.org/r/88722/#review88018
Attachment #8804896 - Flags: review?(gl) → review+
Comment hidden (mozreview-request)

Comment 10

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3d6e90d77c8d
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52

Updated

a year ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.