1311520 - Make fx-team read-only except for sheriffs and people who have pushed recently

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Gregory Szorc [:gps]]

This is the next step towards bug 1296046.

Comment 1

[Gregory Szorc [:gps]]

Attachment: hghooks: make fx-team read-only except for sheriffs and heavy users (bug 1311520);

We limit users who can push to people in the "scm_autoland" group
(essentially sheriffs) and people who have made 10 or more pushes since
September 1.

Review commit: https://reviewboard.mozilla.org/r/87004/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/87004/

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8802682 [details]
hghooks: make fx-team read-only except for sheriffs and heavy users (bug 1311520);

https://reviewboard.mozilla.org/r/87004/#review86072

::: hghooks/mozhghooks/fxteam_retirement.py:45
(Diff revision 1)
>      ui.write('%s\n' % header)
>      ui.write('The fx-team repository is in the process of being retired.\n')
>      ui.write('\n')
>      ui.write('Push access to this repository will be going away.\n')
>      ui.write('\n')
> -    ui.write('The repository will become read-only on October 3 except to\n')
> +    ui.write('The repository become read-only on October 19 except to\n')

s/become/became

::: hghooks/tests/test-fxteam-retirement.t:26
(Diff revision 1)
> +  ************************************************************************
> +  The fx-team repository is in the process of being retired.
> +  
> +  Push access to this repository will be going away.
> +  
> +  The repository become read-only on October 19 except to

s/become/became

::: hghooks/tests/test-fxteam-retirement.t:54
(Diff revision 1)
>    ************************************************************************
>    The fx-team repository is in the process of being retired.
>    
>    Push access to this repository will be going away.
>    
> -  The repository will become read-only on October 3 except to
> +  The repository become read-only on October 19 except to

s/become/became

::: hghooks/tests/test-fxteam-retirement.t:80
(Diff revision 1)
>    ************************************************************************
>    The fx-team repository is in the process of being retired.
>    
>    Push access to this repository will be going away.
>    
> -  The repository will become read-only on October 3 except to
> +  The repository become read-only on October 19 except to

s/become/became

Comment 3

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8802682 [details]
hghooks: make fx-team read-only except for sheriffs and heavy users (bug 1311520);

https://reviewboard.mozilla.org/r/87004/#review86074

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8802682 [details]
hghooks: make fx-team read-only except for sheriffs and heavy users (bug 1311520);

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/87004/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/3a8c63c428bf
hghooks: make fx-team read-only except for sheriffs and heavy users ; r=jgriffin