Closed
Bug 1311536
Opened 8 years ago
Closed 8 years ago
Stop importing chrome://global/skin/global.css in DevTools HTML files
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(firefox52 fixed)
RESOLVED
FIXED
Firefox 52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: ntim, Assigned: Towkir, Mentored)
Details
(Keywords: good-first-bug, Whiteboard: [lang=html])
Attachments
(1 file)
|
2.76 KB,
patch
|
ntim
:
review+
|
Details | Diff | Splinter Review |
chrome://global/skin/global.css provides the base styles for XUL, in fact, all the rules in there only apply to XUL elements (because the XUL namespace is set as default, and there is no mention of the XHTML one). This is why we should stop importing chrome://global/skin/global.css (or its alias chrome://global/skin)
|
Reporter | |
Comment 1•8 years ago
|
||
All imports of chrome://global/skin/ in HTML files: https://dxr.mozilla.org/mozilla-central/search?q=path%3Adevtools%2F+chrome%3A%2F%2Fglobal%2F+ext%3Axhtml+ext%3Ahtml&redirect=false
|
|
Reporter | |
Updated•8 years ago
|
|
Assignee | |
Comment 2•8 years ago
|
||
Hi Tim, what is to be done with the results of the dxr link ? Thanks
|
|
Assignee | |
Updated•8 years ago
|
Flags: needinfo?(ntim.bugs)
|
|
Reporter | |
Comment 3•8 years ago
|
||
(In reply to [:Towkir] Ahmed from comment #2) > Hi Tim, what is to be done with the results of the dxr link ? > Thanks For each of the files listed in the DXR link, remove : <link rel="stylesheet" href="chrome://global/skin/global.css" type="text/css"/> or <link rel="stylesheet" href="chrome://global/skin/"/>
Flags: needinfo?(ntim.bugs)
|
|
Assignee | |
Comment 4•8 years ago
|
||
Here is the patch
|
|
Reporter | |
Comment 5•8 years ago
|
||
Comment on attachment 8803467 [details] [diff] [review] donotimport_globalcss.patch Review of attachment 8803467 [details] [diff] [review]: ----------------------------------------------------------------- Thanks again for the patch! Works great locally
Attachment #8803467 -
Flags: review?(ntim.bugs) → review+
|
|
Reporter | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/46fc6657ec4a Stop importing chrome://global/skin/global.css in DevTools HTML files. r=ntim
Keywords: checkin-needed
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/46fc6657ec4a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•