|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
58 bytes, text/x-review-board-request
|Details | Review|
I see this in my browser console - I haven't dug further.
Augh, this completely breaks the sync ping. Tested that patch in the console initially then messed up when transcribing, and assumed that either TPS or the unit tests would catch it... Regardless, I've verified that the ping is really submitted with the expected data now. Filed a followup bug 1312015 for making TPS more sensitive to telemetry errors.
Assignee: nobody → tchiovoloni
Status: NEW → ASSIGNED
Priority: -- → P1
Is this related to another bug in the console I am getting just after this: TypeError: box.getNotificationWithValue is not a function browser-media.js:257:9 Thanks
It seems extremely unlikely, I don't have that in my log and this code is very far removed from anything having to do with media.
(In reply to Jonathan Kingston [:jkt] from comment #4) > Is this related to another bug in the console I am getting just after this: > > TypeError: box.getNotificationWithValue is not a function > browser-media.js:257:9 > > Thanks No, please could you file a separate bug for that with a complete stack for that error (should be possible to expand it in the browser console) ? If this is on linux I suspect issues with a completely different recent patch (bug 1263665).
Comment on attachment 8803367 [details] Bug 1311611 - Fix property typo in sync ping building code. https://reviewboard.mozilla.org/r/87670/#review86790
Attachment #8803367 - Flags: review?(markh) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/b7555f805721 Fix property typo in sync ping building code. r=markh
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Gijs I'm unable to replicate the error since the last few updates, it was linux and I am unable to se that other bug. There was also no stack trace other than error itself.
Flags: needinfo?(jkt) → needinfo?(gijskruitbosch+bugs)
(In reply to Jonathan Kingston [:jkt] from comment #10) > Gijs I'm unable to replicate the error since the last few updates, it was > linux and I am unable to se that other bug. There was also no stack trace > other than error itself. I think this is bug 1312416 now.
You need to log in before you can comment on or make changes to this bug.