1311611 - Browser console error: TypeError: remoteDevices is undefined - telemetry.js:284:7

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P1)

Description

[Mark Hammond [:markh] [:mhammond]]

I see this in my browser console - I haven't dug further.

Comment 1

[:Gijs (he/him)]

Same here.

Comment 2

[Thom Chiovoloni [:tcsc] (ex-moco)]

Attachment: Bug 1311611 - Fix property typo in sync ping building code.

Review commit: https://reviewboard.mozilla.org/r/87670/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/87670/

Comment 3

[Thom Chiovoloni [:tcsc] (ex-moco)]

Augh, this completely breaks the sync ping. 

Tested that patch in the console initially then messed up when transcribing, and assumed that either TPS or the unit tests would catch it...

Regardless, I've verified that the ping is really submitted with the expected data now. Filed a followup bug 1312015 for making TPS more sensitive to telemetry errors.

Comment 4

[Jonathan Kingston [:jkt] he/him]

Is this related to another bug in the console I am getting just after this:

TypeError: box.getNotificationWithValue is not a function  browser-media.js:257:9

Thanks

Comment 5

[Thom Chiovoloni [:tcsc] (ex-moco)]

It seems extremely unlikely, I don't have that in my log and this code is very far removed from anything having to do with media.

Comment 6

[:Gijs (he/him)]

(In reply to Jonathan Kingston [:jkt] from comment #4)
> Is this related to another bug in the console I am getting just after this:
> 
> TypeError: box.getNotificationWithValue is not a function 
> browser-media.js:257:9
> 
> Thanks

No, please could you file a separate bug for that with a complete stack for that error (should be possible to expand it in the browser console) ? If this is on linux I suspect issues with a completely different recent patch (bug 1263665).

Comment 7

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8803367 [details]
Bug 1311611 - Fix property typo in sync ping building code.

https://reviewboard.mozilla.org/r/87670/#review86790

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7555f805721
Fix property typo in sync ping building code. r=markh

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b7555f805721

Comment 10

[Jonathan Kingston [:jkt] he/him]

Gijs I'm unable to replicate the error since the last few updates, it was linux and I am unable to se that other bug. There was also no stack trace other than error itself.

Comment 11

[:Gijs (he/him)]

(In reply to Jonathan Kingston [:jkt] from comment #10)
> Gijs I'm unable to replicate the error since the last few updates, it was
> linux and I am unable to se that other bug. There was also no stack trace
> other than error itself.

I think this is bug 1312416 now.