1311629 - 'Undo' closed tabs button should have pressed state

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect, P3)

Description

[Catalin Suciu [:csuciu]]

When tapping on 'Undo' closed tabs button there's no feedback. The button should have a pressed state.

Comment 1

[shrvan]

Hello ,I want to work on this bug . is this still valid ? could you tell how can i resolve it ?

Comment 2

[Stephan Leroux [:sleroux]]

Hey shrvan,

This bug is still valid. As a starting point, you can check out the code that creates the toast that appears when the user closes all the tabs. Specifically, here's where we construct the button in question that has no pressed state: https://github.com/mozilla-mobile/firefox-ios/blob/master/Client/Frontend/Browser/ButtonToast.swift#L63

The button is custom drawn and doesn't use an image so it's a bit more involved than setting an image for the selected state. One approach you can try is to create a private UIButton subclass in the same file and override the `setSelected` method to toggle the background/text color. The button right now has a clear background with white text so I'd probably make the selected state use a white background with clear text. 

I'll go ahead and assign this bug to you.

Comment 3

[Dhilip]

Is there any progress on this bug. I would like to fix this one

Comment 4

[Aaron Train [:aaronmt]]

It looks like this bug has stalled. Feel free to work on it. All patches are welcome.

Comment 5

[Stephan Leroux [:sleroux]]

I'll go ahead and re-assign.

Comment 6

[nginsler]

Hey, noticed no progress on this issue so went ahead and fixed it here 
https://github.com/mozilla-mobile/firefox-ios/pull/2302

Comment 7

[nginsler]

Attachment: Pull request

Comment 8

[Stephan Leroux [:sleroux]]

master 0218c37044e9bed4c47bbb685adbf8864e6b6a14

Comment 9

[Stephan Leroux [:sleroux]]

Thanks for the contribution!